Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portland #1 #315

Merged
merged 19 commits into from
Apr 5, 2024
Merged

Portland #1 #315

merged 19 commits into from
Apr 5, 2024

Conversation

JohnGilb
Copy link
Contributor

@JohnGilb JohnGilb commented Apr 4, 2024 •
edited
Loading

Why are we doing this?

  • SubwooferShotFromBotThenTwoCenterline - upgrades to make it more reliable. Trying to reduce wheel slip as we drive out; and also go for note 4 instead of 5 first to give us some flexibility.
  • NoteAcquisitionLogic upgrades to include searching via rotation, and also removing the "back up" phase. (Might want to bring this back at some point)
  • When waiting for a Note when collecting in auto, wait for true stability (0.10 seconds) before advancing to other auto states
  • More error handling for the DynamicOracle
    Asana task URL:

Whats changing?

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot

@JohnGilb
First pass of adding corner camera detection to auto
0643c2b
@JohnGilb
Works, but only once
9b9a732
@JohnGilb
Merge branch 'main' into feature/CornerCamerasReturnedToNoteCollection
48d94e5
@JohnGilb
Merge branch 'main' into feature/CornerCamerasReturnedToNoteCollection
26cf9e3 
# Conflicts:
#	src/main/java/competition/subsystems/vision/NoteSeekLogic.java
@JohnGilb
Nicer timeouts part 1
8e8cc29
@JohnGilb
Different current limits for auto
7ab43e0
@JohnGilb
Newer commonlib
0cd1b44
@JohnGilb
Newer SCL
2508060
@JohnGilb
Drive back with some flexibility in where we stop
4a71c88
@JohnGilb
Try protecting oracle
5bdc26d
@JohnGilb
Brutal hack to avoid issues
da6b089
@JohnGilb
stable collection
25086f3
@JohnGilb
no back up, only rotate
542aace
@JohnGilb
Merge branch 'feature/Portland1' into feature/CornerCamerasReturnedTo…
c7b69d4 
…NoteCollection

# Conflicts:
#	src/main/java/competition/subsystems/vision/NoteSeekLogic.java
@JohnGilb
fix a
7d980ab
@JohnGilb
Merge branch 'main' into feature/CornerCamerasReturnedToNoteCollection
07e6b30
@JohnGilb
Change order to improve chances of vision working when rotating
b2dd1fc
@JohnGilb
newer SCL
116efd3
@JohnGilb
newer SCL
f17f9f8
@JohnGilb JohnGilb marked this pull request as ready for review April 5, 2024 05:41
@JohnGilb JohnGilb requested a review from a team as a code owner April 5, 2024 05:41
@JohnGilb JohnGilb changed the title Feature/corner cameras returned to note collection logic Portland #1 Apr 5, 2024
@JohnGilb JohnGilb merged commit 08f83ca into main Apr 5, 2024
7 checks passed
@JohnGilb JohnGilb deleted the feature/CornerCamerasReturnedToNoteCollection branch April 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohnGilb