Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid point at note (likely a failure) #288

Closed
wants to merge 1 commit into from

Conversation

Rongrrz
Copy link
Contributor

@Rongrrz Rongrrz commented Mar 30, 2024

Why are we doing this?

Asana task URL:

What's changing?

Questions/notes for reviewers

Is this a state machine? I don't think so. Does it work? Probably not. (._.). I originally thought of doing a whileTrue command that can run a point at note command inside it depending on the state, but couldn't figure out how to run a command inside a command... I tried to not interfere (code-wise) with the point at note commands we already have.

How this was tested

  • unit tests added
  • tested on robot

Is this a state machine? I don't think so.
@Rongrrz Rongrrz requested a review from a team as a code owner March 30, 2024 21:50
Copy link
Contributor

@aschokking aschokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this approach wont work because you can't addCommands inside an instant command, it's already too late once the command group is started to modify things. Let's look at this together next time!

@aschokking aschokking closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants