-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solenoid option to flipper (no longer needed?) #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@@ -37,7 +37,6 @@ protected void initializeSystems() { | |||
getInjectorComponent().swerveDefaultCommandMap(); | |||
getInjectorComponent().operatorCommandMap(); | |||
getInjectorComponent().lightSubsystem(); | |||
getInjectorComponent().flipperSubsystem(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we already do dataFrameRefreshables.add(getInjectorComponent().flipperSubsystem());? I thought it was unnecessary
Yeah let's shelve this for now, mech is pessimistic about being able to make pneumatics work in practice now unfortunately. |
Why are we doing this?
In case Mechanical wants to do something fancy with our limited oxygen on earth (😢) and use pistons instead of servos.
Asana task URL: https://app.asana.com/0/38541457243752/1206936581033227/f
Whats changing?
We killed servos and obliterated like 3 DoubleProperties!!!!!!!!
...Well, they are back.
Questions/notes for reviewers
Don't think we need to do anything with refreshDataFrame, right...? Also, channels are temporary. And also, don't commit this until Mechanical figures out what to do with the uhhh amp scoring mechanism.
How this was tested