Solenoid option to flipper (no longer needed?) #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
approved these changes
Mar 27, 2024
| @@ -37,7 +37,6 @@ protected void initializeSystems() { | |||
| getInjectorComponent().swerveDefaultCommandMap(); | |||
| getInjectorComponent().operatorCommandMap(); | |||
| getInjectorComponent().lightSubsystem(); | |||
| getInjectorComponent().flipperSubsystem(); | |||
There was a problem hiding this comment.
Don't we already do dataFrameRefreshables.add(getInjectorComponent().flipperSubsystem());? I thought it was unnecessary
Rongrrz
changed the title
|
Yeah let's shelve this for now, mech is pessimistic about being able to make pneumatics work in practice now unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
In case Mechanical wants to do something fancy with our limited oxygen on earth (😢) and use pistons instead of servos.
Asana task URL: https://app.asana.com/0/38541457243752/1206936581033227/f
Whats changing?
We killed servos and obliterated like 3 DoubleProperties!!!!!!!!
...Well, they are back.
Questions/notes for reviewers
Don't think we need to do anything with refreshDataFrame, right...? Also, channels are temporary. And also, don't commit this until Mechanical figures out what to do with the uhhh amp scoring mechanism.
How this was tested