Update PointAtNoteCommand to use new SCL field oriented gamepad vectors #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
I found writing this field oriented logic in PointAtNoteCommand confusing and error prone.
Whats changing?
Inside SCL there's now a method on gamepad to get field oriented vectors for joysticks to make subsequent math easy hopefully. This depends on SCL PR: Team488/SeriouslyCommonLib#473
Future work
I didn't touch the field oriented swerve drive logic
How this was tested