Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Arm Fine Adjustment & Auto Program Setting #147

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

JohnGilb
Copy link
Contributor

@JohnGilb JohnGilb commented Mar 2, 2024

Why are we doing this?

Fixing a bug where the operator's D-pad would not move the arm in small increments.
Also set up the basics for "auto setters" so we can choose auto while the robot is disabled.
Asana task URL:

Whats changing?

  • Removed the default "set arm target to current position" in the default command map, as that was blowing away settings made by SetArmExtensionCommand.
  • Auto programs can be set via commands (such as using the bottom buttons on the neotrellis)

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot
  • tested in simulator

@JohnGilb JohnGilb requested a review from a team as a code owner March 2, 2024 17:19
@JohnGilb JohnGilb merged commit 53298d8 into main Mar 2, 2024
1 check passed
@JohnGilb JohnGilb deleted the feature/RestoreArmFineAdjustment branch March 2, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant