Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Practice Field #144

Merged
merged 11 commits into from
Mar 2, 2024
Merged

Prepare for Practice Field #144

merged 11 commits into from
Mar 2, 2024

Conversation

JohnGilb
Copy link
Contributor

@JohnGilb JohnGilb commented Mar 2, 2024

Why are we doing this?

I did a pass on a number of missing things we needed before hitting the practice field, while also making miscellaneous updates as I went along.
Asana task URL:

What's changing?

  • Misc changes:
    • Temporarily stopped vision from directly updating odometry, though we will keep and log a copy of all vision and vision-fused odometry to help us debug things and understand when its time to re-enable.
    • Rename several scoring locations to include "Blue", such as BlueSubwooferCentralScoringLocation, for clarity on when they need to be flipped for red alliance
    • Added some "teleport" buttons to the driver gamepad for the three simplest starting conditions (top/middle/bottom subwooer)
    • Fixed a long-standing bug where the robot would ignore small rotation commands from the driver due to two layers of deadbands
    • Fixed a bug where the robot would drive backwards if you were on the red alliance
  • Oracle changes
    • Added a button to "update" the NoteMap and ScoringPositionMap based on what alliance you're on. (for example, invalidating the blue scoring positions when you are on red alliance
    • Set up some unused functions to mark some scoring positions as reserved by others in autonomous
    • Added a way to "link" reserved notes together so the robot won't try to "slip" between them, since if they are reserved we shouldn't be driving in that general area anyway.
    • Prevented the robot from firing a note if arm is at height, and wheel is at speed, BUT the robot isn't done rotating to face the speaker. Can be consumed by any command via PoseSubsystem.getAngularErrorToSpeakerInDegrees()

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot
  • tested in simulator

@JohnGilb JohnGilb marked this pull request as ready for review March 2, 2024 08:06
@JohnGilb JohnGilb requested a review from a team as a code owner March 2, 2024 08:06
@JohnGilb JohnGilb merged commit 424692b into main Mar 2, 2024
1 check passed
@JohnGilb JohnGilb deleted the feature/DecoupleVision branch March 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant