-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Auto Upgrades #142
Conversation
For tested in simulator, I'd like to propose that going forward we include videos of it in the PRs, I think it would help make things a lot easier to understand. What do you think? |
@@ -81,6 +81,11 @@ public class ArmSubsystem extends BaseSetpointSubsystem<Double> implements DataF | |||
private int totalLoops = 0; | |||
private int loopsWhereCompressorRunning = 0; | |||
|
|||
private static double[] experimentalRangesInInches = new double[]{0, 36, 49.5, 63, 80, 111, 136}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ⭐ should our short-run thing be an array with only 1 item in it at the subwoofer distance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That way getMaximumRangeForAnyShotMeters would be limited naturally to that distance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll update - two entries is less likely to cause issues, so I'll just have the range be between 0 and subwoofer*1.2 or so.
* Should be called in AutonomousInit | ||
*/ | ||
public void freezeConfigurationForAutonomous() { | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ note about what this should eventually do?
public static Pose2d CenterLine3 = new Pose2d(8.2956, 4.1056, new Rotation2d()); | ||
public static Pose2d CenterLine4 = new Pose2d(8.2956, 2.4292, new Rotation2d()); | ||
public static Pose2d CenterLine5 = new Pose2d(8.2956, 0.7528, new Rotation2d()); | ||
public static Pose2d CenterLine1 = new Pose2d(8.2705, 7.4584, new Rotation2d()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ should these be a shared number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it to the BasePoseSubsystem and reference it here.
Why are we doing this?
Adding more features to the dynamic auto in preparation for the upcoming event.
Asana task URL:
Whats changing?
AgainstObstacle
, to instruct the robot to try something different to deal with the note near the stage.Questions/notes for reviewers
How this was tested