Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results after Shooter Testing #109

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Results after Shooter Testing #109

merged 2 commits into from
Feb 20, 2024

Conversation

JohnGilb
Copy link
Contributor

Why are we doing this?

The robot is mostly feature-complete; these are mostly small changes needed to operate the machine for testing, particularly shooter testing.
Asana task URL:

Whats changing?

  • Renames of some important position enums
  • Organizing operator controls into a "basic" and "advanced" gamepad. Basic for simple/emergency operations, advanced for 1-button solutions.
  • Changing most motors to Coast when idle. For the Arm, this is to support manually moving it after a match. For others, it's to allow mechanical a better sense of how much native resistance there is in the system.
  • Moving away from "angle" in the arm and using only "millimeters of extension" for now, as it's very easy to measure.
  • Added data from testing the real shooter against the speaker.

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot

@JohnGilb JohnGilb requested a review from a team as a code owner February 20, 2024 01:51
@JohnGilb JohnGilb merged commit 36fbf53 into main Feb 20, 2024
1 check passed
@JohnGilb JohnGilb deleted the feature/prepForShooterTesting branch February 20, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant