Merge branch 'RongruiArmSkeleton' of https://github.com/Team488/XBot2024

 into RongruiArmSkeleton

.github/pull_request_template.md

@@ -1,5 +1,7 @@
 # Why are we doing this?
 
+Asana task URL:
+
 # Whats changing?
 
 # Questions/notes for reviewers

.github/workflows/comment-on-task.yaml

@@ -0,0 +1,17 @@
+on:
+  pull_request:
+    types: [opened, closed, reopened, edited, converted_to_draft, ready_for_review]
+
+jobs:
+  create-comment-in-asana-task-job:
+    runs-on: ubuntu-latest
+    name: Create a comment in Asana Task
+    steps:
+      - name: Create a comment
+        uses: Asana/[email protected]
+        id: createComment
+        with:
+          asana-secret: ${{ secrets.ASANA_SECRET }}
+          comment-text: "{{PR_NAME}} is {{PR_STATE}}: {{PR_URL}}"
+      - name: Get status
+        run: echo "Status is ${{ steps.createComment.outputs.status }}"

.github/workflows/create-asana-attachment.yml

@@ -0,0 +1,16 @@
+on:
+  pull_request:
+    types: [opened, reopened, edited, converted_to_draft, ready_for_review]
+
+jobs:
+  create-asana-attachment-job:
+    runs-on: ubuntu-latest
+    name: Create pull request attachments on Asana tasks
+    steps:
+      - name: Create pull request attachments
+        uses: Asana/create-app-attachment-github-action@latest
+        id: postAttachment
+        with:
+          asana-secret: ${{ secrets.ASANA_SECRET }}
+      - name: Log output status
+        run: echo "Status is ${{ steps.postAttachment.outputs.status }}"

src/main/java/competition/subsystems/arm/ArmSubsystem.java

@@ -20,6 +20,7 @@ public class ArmSubsystem extends BaseSubsystem {
 
     public DoubleProperty extendPower;
     public DoubleProperty retractPower;
+
     private DoubleProperty setPowerMax;
     private DoubleProperty setPowerMin;
 
@@ -37,7 +38,7 @@ public ArmSubsystem(PropertyFactory pf, XCANSparkMax.XCANSparkMaxFactory sparkMa
 
         extendPower = pf.createPersistentProperty("ExtendPower", 0.1);
         retractPower = pf.createPersistentProperty("RetractPower", 0.1);
-
+      
         setPowerMax = pf.createPersistentProperty("SetPowerMax", 0.5);
         setPowerMin = pf.createPersistentProperty("SetPowerMin", -0.5);
 

src/main/java/competition/subsystems/collector/commands/IntakeUntilNoteCollectedCommand.java

@@ -10,6 +10,7 @@ public class IntakeUntilNoteCollectedCommand extends BaseCommand {
     @Inject
     public IntakeUntilNoteCollectedCommand(CollectorSubsystem collector) {
         this.collector = collector;
+        addRequirements(collector);
     }
     @Override
     public void initialize() {

src/main/java/competition/subsystems/drive/commands/TankDriveWithJoysticksCommand.java

@@ -16,7 +16,7 @@ public class TankDriveWithJoysticksCommand extends BaseCommand {
     public TankDriveWithJoysticksCommand(OperatorInterface oi, DriveSubsystem driveSubsystem) {
         this.oi = oi;
         this.driveSubsystem = driveSubsystem;
-        this.addRequirements(this.driveSubsystem);
+        this.addRequirements(driveSubsystem);
     }
 
     @Override

src/main/java/competition/subsystems/vision/VisionSubsystem.java

@@ -39,7 +39,7 @@ public class VisionSubsystem extends BaseSubsystem implements DataFrameRefreshab
     public static final String TARGET_POSE = "forwardAprilCamera/targetPose";
     public static final String LATENCY_MILLIS = "forwardAprilCamera/latencyMillis";
 
-    //final PhotonCamera forwardAprilCamera;
+    final PhotonCameraExtended forwardAprilCamera;
     final PhotonCameraExtended rearAprilCamera;
 
     //final XPhotonCamera akitForwardAprilCamera;
@@ -62,11 +62,6 @@ public class VisionSubsystem extends BaseSubsystem implements DataFrameRefreshab
 
     @Inject
     public VisionSubsystem(PropertyFactory pf, RobotAssertionManager assertionManager) {
-
-        // Temporary while waiting for PhotonVision to update and make this plausible
-        // akitForwardAprilCamera = cameraFactory.create("forwardAprilCamera");
-        //akitRearAprilCamera = cameraFactory.create("rearAprilCamera");
-
         this.assertionManager = assertionManager;
         visionTable = NetworkTableInstance.getDefault().getTable(VISION_TABLE);
 
@@ -83,7 +78,7 @@ public VisionSubsystem(PropertyFactory pf, RobotAssertionManager assertionManage
         // of errors. Some sort of VisionReady in the ElectricalContract may also make sense. Similarly,
         // we need to handle cases like not having the AprilTag data loaded.
 
-        //forwardAprilCamera = new PhotonCamera("forwardAprilCamera");
+        forwardAprilCamera = new PhotonCameraExtended("forwardAprilCamera");
         rearAprilCamera = new PhotonCameraExtended("rearAprilCamera");
 
         try {
@@ -106,12 +101,12 @@ public VisionSubsystem(PropertyFactory pf, RobotAssertionManager assertionManage
                 16.421 / PoseSubsystem.INCHES_IN_A_METER),
                 new Rotation3d(0, 0, Math.toRadians(180 + 7.595)));
 
-        /*frontPhotonPoseEstimator = new PhotonPoseEstimator(
+        frontPhotonPoseEstimator = new PhotonPoseEstimator(
                 aprilTagFieldLayout,
                 PhotonPoseEstimator.PoseStrategy.MULTI_TAG_PNP_ON_COPROCESSOR,
                 forwardAprilCamera,
                 robotToCam
-        );*/
+        );
         rearPhotonPoseEstimator = new PhotonPoseEstimator(
                 aprilTagFieldLayout,
                 PhotonPoseEstimator.PoseStrategy.MULTI_TAG_PNP_ON_COPROCESSOR,
@@ -122,9 +117,9 @@ public VisionSubsystem(PropertyFactory pf, RobotAssertionManager assertionManage
 
     public Optional<EstimatedRobotPose>[] getPhotonVisionEstimatedPoses(Pose2d previousEstimatedRobotPose) {
         if (visionWorking) {
-            //var frontEstimatedPose = getPhotonVisionEstimatedPose("Front", frontPhotonPoseEstimator, previousEstimatedRobotPose, frontReliablePoseIsStable);
+            var frontEstimatedPose = getPhotonVisionEstimatedPose("Front", frontPhotonPoseEstimator, previousEstimatedRobotPose, frontReliablePoseIsStable);
             var rearEstimatedPose = getPhotonVisionEstimatedPose("Rear", rearPhotonPoseEstimator, previousEstimatedRobotPose, rearReliablePoseIsStable);
-            return new Optional[] {/*frontEstimatedPose,*/ rearEstimatedPose};
+            return new Optional[] {frontEstimatedPose, rearEstimatedPose};
         } else {
             return new Optional[] {Optional.empty()};
         }
@@ -136,9 +131,10 @@ public Optional<EstimatedRobotPose> getPhotonVisionEstimatedPose(
             estimator.setReferencePose(previousEstimatedRobotPose);
             var estimatedPose = estimator.update();
             // Log the estimated pose, and log an insane value if we don't have one (so we don't clutter up the visualization)
-            Logger.recordOutput(getPrefix()+name+"Estimate", estimatedPose.isPresent()
-                    ? estimatedPose.get().estimatedPose.toPose2d() :
-                    new Pose2d(-1000, -1000, new Rotation2d(0)));
+            if (estimatedPose.isPresent())
+            {
+                Logger.recordOutput(getPrefix()+name+"Estimate", estimatedPose.get().estimatedPose.toPose2d());
+            }
 
             var isReliable = !estimatedPose.isEmpty() && isEstimatedPoseReliable(estimatedPose.get(), previousEstimatedRobotPose);
             var isStable = waitForStablePoseTime.get() == 0.0 || poseTimeValidator.checkStable(isReliable);
@@ -211,6 +207,7 @@ private String getStringFromList(List<Integer> list) {
 
     @Override
     public void refreshDataFrame() {
+        forwardAprilCamera.refreshDataFrame();
         rearAprilCamera.refreshDataFrame();
     }
 }