Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct verifier for DI VCs #613

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Use the correct verifier for DI VCs #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06ec72a
Use the correct verifier for DI VCs
andresuribe87 Jul 28, 2023
113b38c
Merge branch 'main' into issue_612
decentralgabe Jul 28, 2023
1a98331
Merge branch 'main' into issue_612
andresuribe87 Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/credential/verification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
"github.com/TBD54566975/ssi-sdk/credential/integrity"
"github.com/TBD54566975/ssi-sdk/credential/validation"
"github.com/TBD54566975/ssi-sdk/crypto"
"github.com/TBD54566975/ssi-sdk/crypto/jwx"
"github.com/TBD54566975/ssi-sdk/cryptosuite/jws2020"
"github.com/TBD54566975/ssi-sdk/did/resolution"
sdkutil "github.com/TBD54566975/ssi-sdk/util"
"github.com/goccy/go-json"
Expand Down Expand Up @@ -99,14 +101,19 @@ func (v Validator) VerifyDataIntegrityCredential(ctx context.Context, credential
}

// construct a signature validator from the verification information
verifier, err := keyaccess.NewDataIntegrityKeyAccess(issuer, verificationMethod, pubKey)
publicKeyJWK, err := jwx.PublicKeyToPublicKeyJWK(verificationMethod, pubKey)
if err != nil {
return sdkutil.LoggingErrorMsgf(err, "could not convert private key to JWK: %s", verificationMethod)
}
verifier, err := jws2020.NewJSONWebKeyVerifier(issuer, *publicKeyJWK)
if err != nil {
errMsg := fmt.Sprintf("could not create validator for kid %s", verificationMethod)
return sdkutil.LoggingErrorMsg(err, errMsg)
}

cryptoSuite := jws2020.GetJSONWebSignature2020Suite()
// verify the signature on the credential
if err = verifier.Verify(&credential); err != nil {
if err = cryptoSuite.Verify(verifier, &credential); err != nil {
return sdkutil.LoggingErrorMsg(err, "could not verify the credential's signature")
}

Expand Down
Loading
Loading