Use the correct verifier for DI VCs #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested changes
Jul 28, 2023
| @@ -20,6 +20,340 @@ import ( | |||
| "gopkg.in/h2non/gock.v1" | |||
| ) | |||
|
|
|||
| const w3cCredentialContext = `{ | |||
There was a problem hiding this comment.
can this be loaded from a file instead? I thought we had context caching somewhere else...
There was a problem hiding this comment.
I wasn't aware. I found https://github.com/TBD54566975/ssi-sdk/pull/102/files , but we need to do some more piping in order to have the cache be pre-loaded. Right now, the processor caches documents, but it still needs to fetch them once from the network.
Ok if I take on a follow up? Requires changes in SDK and the service.
There was a problem hiding this comment.
certainly, in the meantime can you move this to a file?
There was a problem hiding this comment.
Tracking in #619
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 27.03% 27.03%
=======================================
Files 48 48
Lines 5830 5830
=======================================
Hits 1576 1576
Misses 3971 3971
Partials 283 283 |
decentralgabe
approved these changes
Jul 28, 2023
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #612 by using the verifier that only has the public key.
Description
This was a simple oversight, as
NewDataIntegrityKeyAccessdoes not accept a public key as the third parameter.How Has This Been Tested?
Added a test the failed before, and passes after. The mock crazyness is all so that json-ld works without having to retrieve things from the network.