Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/wp 209 fix deprecated warnings (part II) #852

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Task/wp 209 fix deprecated warnings (part II) #852

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fc4611e
urls and gettext_lazy
van-go Jun 29, 2023
a7edd56
server-side linting fix
van-go Jul 19, 2023
fa1bffa
Merge remote-tracking branch 'origin/main' into task/wp-171-fix-depre…
van-go Aug 23, 2023
af342a5
task/wp-171-fix-deprecated-django-warnings
van-go Aug 23, 2023
52d61ea
task/wp-209-fix-deprecated-warnings
van-go Aug 24, 2023
1fc16f5
removed commented out code
van-go Aug 30, 2023
a80eab9
Merge branch 'main' into task/wp-209-fix-deprecated-warnings-II
shayanaijaz Sep 8, 2023
a710969
Update signals.py
van-go Sep 15, 2023
e616929
Update pytest.ini
van-go Sep 18, 2023
f034d9d
Merge branch 'main' into task/wp-209-fix-deprecated-warnings-II
chandra-tacc Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion server/portal/apps/signals/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
from django.dispatch import Signal

# Generic event signal. Not in use as of 6.29.20
portal_event = Signal(providing_args=['event_type', 'event_data', 'event_users'])
# portal_event = Signal(providing_args=['event_type', 'event_data', 'event_users'])
van-go marked this conversation as resolved.
Show resolved Hide resolved

# Changes for Django 3.*
van-go marked this conversation as resolved.
Show resolved Hide resolved
portal_event = Signal()
12 changes: 12 additions & 0 deletions server/pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
[pytest]
DJANGO_SETTINGS_MODULE = portal.settings.unit_test_settings
python_files = tests.py *unit_test.py

filterwarnings =
ignore::DeprecationWarning:django.*:
ignore::DeprecationWarning:openapi_schema_validator.*:
ignore::DeprecationWarning:openapi_spec_validator.*:
ignore::DeprecationWarning:openapi_core.*:
ignore::DeprecationWarning:kombu.*:
ignore::DeprecationWarning:pkg_resources.*:
ignore:.*Django now detects this configuration.*:django.utils.deprecation.RemovedInDjango41Warning
Comment on lines +6 to +12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want these warnings removed? I think it might be better if we resolved the deprecation warnings, as in changed code to resolve the warnings, rather than suppressed the warnings.

Copy link
Contributor Author

@van-go van-go Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require updating the Django version. There aren't any changes in our code to make that would resolve these warnings. Do you know when we are planning to update the Django version? We can add a note or ticket to review these warnings.

Copy link
Collaborator

@chandra-tacc chandra-tacc Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@van-go , just so that we do not ignore this permanently, would it be possible to add tracking jira tasks and add the task number to the ini file (comments start with ';' in ini file, afaik).

  • django version fix: 4.2.5
  • openapi:
    openapi_spec_validator 0.5.0
    openapi_schema_validator 0.6.0
    openapi_core 0.18
  • kombu: 5.3.2.
  • which third party throws : django.utils.deprecation.RemovedInDjango41Warning
    Move channels to 4.0.0.

The edits for these will be in dependency list

Adding a note in task to remove the ignore when the task is fixed will ensure that the ignore is not left behind permanently.


markers =
asyncio: mark a test as asyncio.
Copy link
Member

@rstijerina rstijerina Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at end of file

Suggested change
asyncio: mark a test as asyncio.
asyncio: mark a test as asyncio.