Task/wp 209 fix deprecated warnings (part II) #852
Conversation
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 63.05% 63.05%
=======================================
Files 427 427
Lines 12144 12144
Branches 2492 2492
=======================================
Hits 7658 7658
Misses 4281 4281
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
server/pytest.ini
Outdated
| ignore:.*Django now detects this configuration.*:django.utils.deprecation.RemovedInDjango41Warning | ||
|
|
||
| markers = | ||
| asyncio: mark a test as asyncio. |
There was a problem hiding this comment.
Newline at end of file
| asyncio: mark a test as asyncio. | |
| asyncio: mark a test as asyncio. | |
| ignore::DeprecationWarning:django.*: | ||
| ignore::DeprecationWarning:openapi_schema_validator.*: | ||
| ignore::DeprecationWarning:openapi_spec_validator.*: | ||
| ignore::DeprecationWarning:openapi_core.*: | ||
| ignore::DeprecationWarning:kombu.*: | ||
| ignore::DeprecationWarning:pkg_resources.*: | ||
| ignore:.*Django now detects this configuration.*:django.utils.deprecation.RemovedInDjango41Warning |
There was a problem hiding this comment.
Do we want these warnings removed? I think it might be better if we resolved the deprecation warnings, as in changed code to resolve the warnings, rather than suppressed the warnings.
There was a problem hiding this comment.
This would require updating the Django version. There aren't any changes in our code to make that would resolve these warnings. Do you know when we are planning to update the Django version? We can add a note or ticket to review these warnings.
There was a problem hiding this comment.
@van-go , just so that we do not ignore this permanently, would it be possible to add tracking jira tasks and add the task number to the ini file (comments start with ';' in ini file, afaik).
- django version fix: 4.2.5
- openapi:
openapi_spec_validator 0.5.0
openapi_schema_validator 0.6.0
openapi_core 0.18 - kombu: 5.3.2.
- which third party throws : django.utils.deprecation.RemovedInDjango41Warning
Move channels to 4.0.0.
The edits for these will be in dependency list
Adding a note in task to remove the ignore when the task is fixed will ensure that the ignore is not left behind permanently.
Overview
This is a continuation from WP-171.
When running unit tests, a lot of deprecated warnings were appearing. This tickets addresses those warnings.
Related
Changes
The previous ticket [WP-171] addressed issues with our code (Core-Portal). However, a lot of the warnings being seen are issues with Django. To keep these from showing up, they are filtered out;
pytest.ininow has'filterwanrings'.PytestUnknownMarkWarning: Unknown pytest.mark.asynciowas addressed by addingmarkers = asyncio: mark a test as asynciotopytest.iniRemovedInDjango40Warning: The providing_args argument is deprecated.was addressed insignals.pyby redefiningportal_eventas suggested in the Django documentation.Testing
docker exec -it core_portal_django bashpytest -ra portal/apps/auth/api/UI
Notes
Running
pytest -ra portal/apps/shows that some tests are failing, and also has 7 warnings (not deprecation warnings). These might need to be addressed.