refactor: wp-791 dropdown menu #1028
+48
−102
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Why?
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Why?
Footnotes
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,5 +13,5 @@ | |
|
|
||
| .add-button-item { | ||
| padding-bottom: 20px; | ||
| padding-inline: var(--global-space--section-left); | ||
|
|
||
| } | ||
|
There was a problem hiding this comment. Why delete so much? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,70 +10,29 @@ | |
| border-radius: 0; | ||
| } | ||
|
|
||
| #data-files-add { | ||
| width: 100%; | ||
| } | ||
|
Comment on lines
-13
to
15
There was a problem hiding this comment. What did I do? Match design:
|
||
|
|
||
| .data-files-nav { | ||
| padding-top: 20px; | ||
| } | ||
|
|
||
| .data-files-sidebar { | ||
| .dropdown-menu { | ||
| /* To make menu wider than button yet still centered */ | ||
| width: calc(100% + var(--global-space--section-left)); | ||
| left: calc( | ||
| var(--global-space--section-left) / -2 | ||
| ) !important; /* to override `inset` from Popper via Reactstrap */ | ||
| } | ||
| .dropdown-menu::before, | ||
| .dropdown-menu::after { | ||
| left: calc(50% - var(--arrow-size)); | ||
| } | ||
| } | ||
|
|
||
| .complex-dropdown-item { | ||
|
There was a problem hiding this comment. Why?
|
||
| display: flex; | ||
| } | ||
|
|
||
|
|
||
wesleyboar marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. What did I do?
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| ## Overview | ||
|
|
||
| Refactor the styles for Data Files dropdown menus to: | ||
| - share more CSS | ||
| - use clearer CSS | ||
|
|
||
| ## Related | ||
|
|
||
| * [WP-791](https://tacc-main.atlassian.net/browse/WP-791) | ||
| * inspired by https://github.com/TACC/Core-Portal/pull/1018#pullrequestreview-2476250609 | ||
|
|
||
| ## Changes | ||
|
|
||
| **`.dropdown-menu`**: | ||
| - remove redundant code | ||
| - use `<Dropdown>` not `<ButtonDropdown>`[^1] | ||
| - clean up styles | ||
| - use CSS var's for arrow and border | ||
|
|
||
| **`DataFilesBreadcrumbs`**: | ||
| - fix layout of menu and button | ||
|
|
||
| **`DataFilesBreadcrumbs`**: | ||
| - use class not ID | ||
| - position via `top` not `margin-top` | ||
| - explain menu position value | ||
| - explain why positioning is necessary[^2] | ||
|
|
||
| [^1]: I don't see `ButtonDropdown` in [latest ReactStrap (v9)](https://reactstrap.github.io/?path=/docs/components-dropdown--dropdown). | ||
| [^2]: Not desired, but necessary if we use our custom `<Button>` as is. | ||
|
|
||
| ## Testing | ||
|
|
||
| 1. Open Data Files. | ||
| 2. Click "Add +" button. | ||
| - Verify button is centered. | ||
| - Verify menu is centered. | ||
| - Verify menu is wider than button. | ||
| - Verify elements are otherwise unchanged. | ||
| 4. Click "Go to ..." button. | ||
| - Verify elements are unchanged. | ||
|
|
||
| ## UI | ||
|
|
||
| | `DataFilesDropdown` | `DataFilesSidebar` | | ||
| | - | - | | ||
| | <img width="400" alt="DataFilesDropdown" src="https://github.com/user-attachments/assets/c0a35d5b-d304-4625-b94e-6ab7888ec3e4"> | <img width="400" alt="DataFilesSidebar" src="https://github.com/user-attachments/assets/7bec0d60-ec77-45d7-b53d-7c0688d8c75b"> | | ||
|
|
||
| ## Notes | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did I do?
dropdown-menu.cssmanages.topnotmargin-top.Margin is for space between items. Positioning uses specific properties.