Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wp-791 dropdown menu #1028

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Dec 3, 2024

  1. refactor: WP-791 dropdown button menu

    - remove most of the redundant code
    - use Dropdown not ButtonDropdown
    - fix layout of menu and button in DataFilesSidebar
    - clean up our .dropdown-menu styles
    - use variables for arrow and border
    wesleyboar committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    ff8cc9e View commit details
    Browse the repository at this point in the history
  2. refactor: WP-791 DataFilesBread… dropdown menu

    `….scss`:
    - use class not ID
    - position via `top` not `margin-top`
    - explain menu position's "magic" value
    - explain why positioning is necessary[^1]
    
    `….jsx`:
    - use class not ID
    use Dropdown not ButtonDropdown[^2]
    
    [^1]: Not desired, but necessary if we use our custom <Button> as is.
    [^2]: I don't see ButtonDropdown in latest ReactStrap (v9).
    wesleyboar committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    bb73411 View commit details
    Browse the repository at this point in the history
  3. chore: remove class data-files-btn

    This class is assigned to buttons that:
    - **either** have Bootstrap btn-primary
        (in which case the `.workbench-content .btn-primary` styles it)
    - **or** are our custom `<Button>`
        (in which case the `composes: c-button` styles it)
    wesleyboar committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    1b644ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a678c6f View commit details
    Browse the repository at this point in the history
  5. Revert "chore: remove class data-files-btn"

    This reverts commit 1b644ed.
    wesleyboar committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    d6f820b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Configuration menu
    Copy the full SHA
    2840e42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d0317b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a54861 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    958069b View commit details
    Browse the repository at this point in the history