-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: wp-791 dropdown menu #1028
Open
wesleyboar
wants to merge
9
commits into
main
Choose a base branch
from
refactor/WP-791-dropdown-menu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+48
−102
Commits on Dec 3, 2024
-
refactor: WP-791 dropdown button menu
- remove most of the redundant code - use Dropdown not ButtonDropdown - fix layout of menu and button in DataFilesSidebar - clean up our .dropdown-menu styles - use variables for arrow and border
Configuration menu - View commit details
-
Copy full SHA for ff8cc9e - Browse repository at this point
Copy the full SHA ff8cc9eView commit details -
refactor: WP-791 DataFilesBread… dropdown menu
`….scss`: - use class not ID - position via `top` not `margin-top` - explain menu position's "magic" value - explain why positioning is necessary[^1] `….jsx`: - use class not ID use Dropdown not ButtonDropdown[^2] [^1]: Not desired, but necessary if we use our custom <Button> as is. [^2]: I don't see ButtonDropdown in latest ReactStrap (v9).
Configuration menu - View commit details
-
Copy full SHA for bb73411 - Browse repository at this point
Copy the full SHA bb73411View commit details -
chore: remove class data-files-btn
This class is assigned to buttons that: - **either** have Bootstrap btn-primary (in which case the `.workbench-content .btn-primary` styles it) - **or** are our custom `<Button>` (in which case the `composes: c-button` styles it)
Configuration menu - View commit details
-
Copy full SHA for 1b644ed - Browse repository at this point
Copy the full SHA 1b644edView commit details -
Configuration menu - View commit details
-
Copy full SHA for a678c6f - Browse repository at this point
Copy the full SHA a678c6fView commit details -
Revert "chore: remove class data-files-btn"
This reverts commit 1b644ed.
Configuration menu - View commit details
-
Copy full SHA for d6f820b - Browse repository at this point
Copy the full SHA d6f820bView commit details
Commits on Dec 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2840e42 - Browse repository at this point
Copy the full SHA 2840e42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d0317b - Browse repository at this point
Copy the full SHA 1d0317bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a54861 - Browse repository at this point
Copy the full SHA 5a54861View commit details -
Configuration menu - View commit details
-
Copy full SHA for 958069b - Browse repository at this point
Copy the full SHA 958069bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.