Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Stearoyl-CoA Beta-Oxidation Reactions #820

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed in #802:

  • Removes MAR00776 for being a duplicate of MAR03115 + MAR03116 + MAR03117 + MAR03118
  • Removes MAR00778 for being a duplicate of MAR03116 + MAR03117 + MAR03118 + MAR03121 + MAR03122 + MAR03123 + MAR03125 + MAR03128 + MAR03129 + MAR03130 + MAR03132 +MAR03135 + MAR03136 + MAR03137 + MAR03139 + MAR03142 + MAR03143 + MAR03144 + MAR03146

I noticed that MAR00776 had references associated with it but MAR03115, MAR03116, MAR03117, and MAR03118 didn't, but the two references associated with MAR00776 were about ACADS and ACADM, neither of which can actually catalyze the first round of beta-oxidation of stearoyl-CoA (at 18 carbons, it's too long), so I instead associated those four reactions with PMID:20490924, a review of mitochondrial beta-oxidation. MAR03121 onwards all had several references already associated with them, so I left those alone.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@Devlin-Moyer Devlin-Moyer requested a review from feiranl May 9, 2024 22:38
@Devlin-Moyer Devlin-Moyer linked an issue May 9, 2024 that may be closed by this pull request
2 tasks
@Devlin-Moyer
Copy link
Collaborator Author

it would be easier to figure out what went wrong with the metabolic tasks if the test indicated which tasks failed rather than just saying that the test as a whole failed (if this information is in the output somewhere and I'm just not seeing it, let me know)

@feiranl
Copy link
Collaborator

feiranl commented May 11, 2024

@JHL-452b Could you help check this?

@JHL-452b
Copy link
Collaborator

JHL-452b commented May 11, 2024

it would be easier to figure out what went wrong with the metabolic tasks if the test indicated which tasks failed rather than just saying that the test as a whole failed (if this information is in the output somewhere and I'm just not seeing it, let me know)

Yeah. In the current code, it would exit the matlab program directly if the task failed without any feedback. This suggestion should be incorporated into plans for subsequent improvements.

However, in this bug, I tested on my own computer and finded that the task of Growth on Ham's media (biomass production) failed. The cause of the failure is being analyzed, and will provide feedback as soon as possible when there are conclusions.

@JHL-452b
Copy link
Collaborator

JHL-452b commented May 12, 2024

Actually, the failed task seems to have nothing to do with the modification of this PR due to same problem occured when I re-run the task for ./develop/Human-GEM.

I tried changing the solver to gurobi, and all tasks succeeded as you can see below:

>> taskType = 'essential';
>> setRavenSolver('glpk')
>> status = testMetabolicTasks(taskType)
Boundary metabolites were added to 1660 reactions.
New (boundary) versions of 1660 metabolites were added to the model.

FAIL: [GR] Growth on Ham's media (biomass production)
status =
     0

>> setRavenSolver('gurobi')
>> status = testMetabolicTasks(taskType)
Boundary metabolites were added to 1660 reactions.
New (boundary) versions of 1660 metabolites were added to the model.

Suceeded with essential tasks.
status =
     1

I don't know why RAVEN cannot automatically change the solver to gurobi in the running code of those tasks now. If we don't resolve it, all subsequent PR will fail. If there is no problem with the recently updated content, can we directly add setRavenSolver('gurobi') to the code of tasks? @feiranl

@edkerk
Copy link
Member

edkerk commented May 13, 2024

See #821 (comment) for consideration regarding gurobi/glpk.

Copy link

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1514 dead-end metabolites.
- Found 1319 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1977 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 447 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 447 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

@SysBioChalmers SysBioChalmers deleted a comment from github-actions bot Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Stearoyl-CoA Beta-Oxidation Reactions
4 participants