Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of essential tasks under default solver #821

Closed
JHL-452b opened this issue May 13, 2024 · 2 comments
Closed

Failure of essential tasks under default solver #821

JHL-452b opened this issue May 13, 2024 · 2 comments
Labels

Comments

@JHL-452b
Copy link
Collaborator

Current behavior:

As we discussed in #820, if there is no problem with recently updated content, two bug in current metabolic tasks:

  • Essential tasks failed under default solver(GLPK), but not with gurobi;
  • Failed tasks could not get any feedback.

Proposed changes:

Modify the line 38 in the testMetabolicTasks function as below

setRavenSolver('gurobi')
% change the third parameter to `true` to printOutput.
verificationTaskReport=checkTasks(model,[],true,true,false,verificationTasks);
@JHL-452b JHL-452b added the bug label May 13, 2024
@edkerk
Copy link
Member

edkerk commented May 13, 2024

Regarding the solver in #820 is suggested that RAVEN should automatically swap solvers. This would not be preferred behaviour of native RAVEN functions, to swap mid-function to a different solver that might not be installed on the user's computer. A better behaviour is indeed to set the preferred RAVEN solver before running testMetabolicTasks. However, that would make this task depend on gurobi, which again might not always be installed/functional.

Irrespective, this tasks shouldn't fail with glpk. I looked into the RAVEN code, and it seems like some glpk parameters are incorrectly set, which cause the FBA here to time out.

This is now solved in SysBioChalmers/RAVEN#539, which will soon end up in RAVEN 2.9.1 release.

The printOutput parameter should still be resolved in this repo.

@feiranl
Copy link
Collaborator

feiranl commented Jun 17, 2024

RAVEN 2.9.1 has released, the issue has been fixed.

@feiranl feiranl closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants