Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use staticcheck instead of golangci-lint #1688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use staticcheck instead of golangci-lint #1688

wants to merge 1 commit into from

Commits on Oct 18, 2024

  1. Use staticcheck instead of golangci-lint 

    This commit changes the definition of the "golint" make target. It now
uses staticcheck instead of golangci-lint.

Most of the value in golangci-lint is derived from staticcheck, and
staticcheck on its own runs in about 25% of the time as golangci-lint.
So, there is little reason to use golangci-lint.

Additionally, golangci-lint configures staticcheck in a non-standard
way. As such, some lint errors were masked. They have been fixed in this
commit as well.

Signed-off-by: Eric Chlebek <[email protected]>
    @echlebek
    echlebek committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9def225 View commit details
    Browse the repository at this point in the history