Use staticcheck instead of golangci-lint #1688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the definition of the "golint" make target. It now uses staticcheck instead of golangci-lint. Most of the value in golangci-lint is derived from staticcheck, and staticcheck on its own runs in about 25% of the time as golangci-lint. So, there is little reason to use golangci-lint. Additionally, golangci-lint configures staticcheck in a non-standard way. As such, some lint errors were masked. They have been fixed in this commit as well. Signed-off-by: Eric Chlebek <[email protected]>
|
Reviewers can see the lint errors for themselves by running this on the main branch: |
| changeType: eventChangeTypeAdded, | ||
| event: event, | ||
| } | ||
| opts := cache.InformerOptions{ |
There was a problem hiding this comment.
Should we raise a different PR for this change?, I think we'll need a changelog entry for this, since we're cutting over to a new function.
There was a problem hiding this comment.
In my opinion this is a simpler change than it may seem outwardly. If you have a look at the definition of cache.NewInformer, it just calls cache.NewInformerWithOptions in the same way it's called here. There would be no change to communicate in the changelog.
There was a problem hiding this comment.
(cache.NewInformer is deprecated, and a notice has been added to switch to cache.NewInformerWithOptions)
rnishtala-sumo
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the definition of the "golint" make target. It now uses staticcheck instead of golangci-lint.
Most of the value in golangci-lint is derived from staticcheck, and staticcheck on its own runs in about 25% of the time as golangci-lint. So, there is little reason to use golangci-lint.
Additionally, golangci-lint configures staticcheck in a non-standard way. As such, some lint errors were masked. They have been fixed in this commit as well.