-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove URL-rewriting hack #1519
base: main
Are you sure you want to change the base?
Conversation
Notes for reviewers:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good to me, but we should check against a few more environments than just us2. We should also get approval from the relevant Opamp backend SMEs before merging this imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this changes behind feature flag rather removing the old code.
As the otrm for existing customers will break till we test this feature end-to-end on production.
@skumar-sumo I don't see the logic of having a feature flag here, what's the suggested default? Can't we support both the old and new strategy on the backend? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will break OT remote management. As of now,
- Backend changes are not tested. Its pending on Agent build that supports http/wss redirection.
- After testing with Agent, BE solution will be rollout on test environment and then to small prods.
- We would also need QE sign off on the redirection solution to rollout everywhere.
- We don't have a rollback solution discussed or in place. (Hope we don't need it)
After, 1, 2 and 3 is done. We can safely remove Agent side hack.
The agent side hack has been shown to be buggy and does not work correctly in all circumstances. Per recent discussion, it should be removed. |
03804d8
to
243221c
Compare
@echlebek re: setting the opamp endpoint - the install script has moved to the packaging repository. |
QE has found an issue with this PR, will update. |
243221c
to
b607398
Compare
This commit removes a hack that rewrites the collector URL for use with OpAmp. The collector now supports redirection, and we expect the Sumo Logic backend to correctly redirect the client.
When the OpAmp URL is not explicitly configured, use the default SumoLogic URL.
946bfd4
to
d355edc
Compare
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
This commit removes a hack that rewrites the collector URL for use with OpAmp. The collector now supports redirection, and we expect the Sumo Logic backend to correctly redirect the client.