Add --opamp-api-url flag to unix install script #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echlebek
force-pushed
the
install-script
branch
from
1ef97b7
to
ea8312c
Compare
|
Blocked on #78 |
swiatekm
reviewed
Apr 30, 2024
|
@swiatekm-sumo I will endeavour to do so! |
echlebek
force-pushed
the
install-script
branch
from
ea8312c
to
972a890
Compare
|
Now, the darwin install script test has failed because: I will try to re-run it to see if it is transient. |
|
The tests have now failed successfully. I will file an issue about the transient CI error. |
This commit adds a new flag to the install script, responsible for setting the OpAmp API URL. Previously, the OpAmp API URL was computed from the API URL. However, this did not work correctly in all scenarios. This change is related to a pending change in the agent and may need to be held back until the agent change is committed.
|
@swiatekm-sumo I modeled this after the other configuration overrides, they basically regex-replace a line of yaml with another line. I'm a little concerned about doing this by searching for the word "endpoint". But I'm not sure how to improve things without adding dependencies (yq, etc). Any thoughts on how to make this more robust? I'm not a very good bash programmer unfortunately. |
|
@swiatekm-sumo I believe this feature is finally working, please take another look. |
rnishtala-sumo
approved these changes
May 21, 2024
|
LGTM! |
ccressent
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag to the install script, responsible for setting the OpAmp API URL.
Previously, the OpAmp API URL was computed from the API URL. However, this did not work correctly in all scenarios.
This change is related to a pending change in the agent and may need to be held back until the agent change is committed.
See SumoLogic/sumologic-otel-collector#1519