Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all appliesto(P2CE) to appliesto(SINCE_P2CE) #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefanH-AT
Copy link

This doesn't change any behavior for P2CE but allows Portal: Revolution to extend P2CEs features

@ozxybox
Copy link
Member

ozxybox commented Mar 23, 2023

Should this just be called PORTAL2_BASE, P2CE_BASE, PORTAL2, or other such?

The name SINCE_P2CE feels a bit odd, especially since it’s past tense and not a game name.

@TeamSpen210
Copy link

Yeah, the right way is to add P2CE to the FEATURES dict, so it'll include that tag too.

@StefanH-AT
Copy link
Author

@TeamSpen210
Copy link

I mean to add "REVOLUTION": ["P2CE", ...].

@StefanH-AT
Copy link
Author

How would this work? I currently have it set up like this and I can't see how I'd apply your suggestion
image

@TeamSpen210
Copy link

I mean you should add "P2CE" to the Revolution set. Then that tag will be set also when exporting for Revolution. You could also just edit your command line to be something like unify_fgd.py export P2CE REVOLUTION, so it'll include all the tags both have.

@StefanH-AT
Copy link
Author

If I add the P2CE tag will that not inherit all feature flags P2CE has? I don't need all those

@JJL772
Copy link
Member

JJL772 commented Apr 17, 2023

I'd create a group called PORTAL2 and include everything that's common between revo and p2ce in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants