Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diff-functionality for SonarQube and align/extend pages #140

Conversation

sebastiaanspeck
Copy link
Contributor

Also added/aligned some pages.

This PR adds the functionality to show the (non)compliant code example using diff.
This only works if we have a non-compliant and a compliant code example.
Screenshot 2024-11-17 at 20 51 05

Screenshot 2024-11-17 at 20 51 50 Screenshot 2024-11-17 at 20 52 04

@sebastiaanspeck sebastiaanspeck marked this pull request as draft November 18, 2024 03:17
@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review November 20, 2024 20:37
@sebastiaanspeck sebastiaanspeck changed the title Use diff-functionality for SonarQube Use diff-functionality for SonarQube and align/extend pages Nov 20, 2024
@StevenLooman
Copy link
Owner

Ready for merge?

@sebastiaanspeck
Copy link
Contributor Author

Ready for merge?

Yes!

@StevenLooman StevenLooman merged commit 1f9c30a into StevenLooman:develop Nov 21, 2024
4 checks passed
@StevenLooman
Copy link
Owner

Thanks!

@sebastiaanspeck sebastiaanspeck deleted the use-diff-functionality-for-sonarqube branch November 21, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants