Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available options to their corresponding Wiki page #144

Merged
merged 12 commits into from
Nov 22, 2024

Conversation

sebastiaanspeck
Copy link
Contributor

@sebastiaanspeck sebastiaanspeck commented Nov 19, 2024

Also moved the Bash code to a Python script

@sebastiaanspeck
Copy link
Contributor Author

For the result: https://github.com/sebastiaanspeck/magik-tools/wiki and https://github.com/sebastiaanspeck/magik-tools/wiki/Checks-Options.

By adding this to the Wiki, IMO #135 will be superfluous. Maybe we can add a link in the magik-lint-help to create some awareness for the Wiki?

@StevenLooman
Copy link
Owner

StevenLooman commented Nov 19, 2024

I think I was too brief in #135. Why do the parameters need to be in on a separate page? Lets add the parameters to the html files of the checks. This way the parameters end up on the wiki automatically.

Adding a separate page adds something which has to be kept in sync manually. Yes, the html has to be kept in sync as well, but it is a bit "closer" to the implementation of the check itself.

@sebastiaanspeck
Copy link
Contributor Author

I think I was too brief in #135. Why do the parameters need to be in on a separate page? Lets add the parameters to the html files of the checks. This way the parameters end up on the wiki automatically.

Adding a separate page adds something which has to be kept in sync manually. Yes, the html has to be kept in sync as well, but it is a bit "closer" to the implementation of the check itself.

That makes things more clear, although adding the parameters to the html is maybe a bit redundant as in SonarQube they are also listed. I could also rewrite the Python file to extract the parameters from the *Check.java and add them to their corresponding Wiki Check-page. That way we do not have to update the HTML ourselves since it is copied straight from the *Check.java.

@StevenLooman
Copy link
Owner

Sounds like a less error prone way indeed. Please do so.

@sebastiaanspeck sebastiaanspeck marked this pull request as draft November 20, 2024 21:01
@sebastiaanspeck sebastiaanspeck changed the title Add page to show all available options Add available options to their corresponding Wiki page Nov 20, 2024
@sebastiaanspeck
Copy link
Contributor Author

This somewhat depends on #140

@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review November 21, 2024 22:10
@StevenLooman
Copy link
Owner

Looks good, thanks!

@StevenLooman StevenLooman merged commit 9c7eef3 into StevenLooman:develop Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants