Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links and site nav glitch, misc cleanup #141

Merged
merged 13 commits into from
Feb 16, 2024
Merged

Fix broken links and site nav glitch, misc cleanup #141

merged 13 commits into from
Feb 16, 2024

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jan 5, 2024

  • Moves the last font file reference to the fonts css file
  • Remove broken links, unused Blazor components and pages, unused nuget package

Fixes #140

@bart-vmware

This comment was marked as resolved.

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment.

bart-vmware

This comment was marked as resolved.

@TimHess
Copy link
Member Author

TimHess commented Jan 24, 2024

In testing the combination of this PR with SteeltoeOSS/Documentation#310, I found the following:
3. Menu entry Projects > Steeltoe Dynamic Logging has disappeared from both sites. When I asked to sync them up, I meant to fix the title/link to be consistent between both sides; not remove the entry altogether.
4. MainSite > Projects > Steeltoe Network File Sharing: throws exception when clicked

  • Note the link from Documentation is named differently ("Steeltoe Network File Shares") and points to a different URL
  • Same issue for the link in footer
  1. Documentation: Make the browser window smaller, so the top-level menu changes into a hamburger menu. Then clicking the hamburger menu shortly expands its entries before auto-collapsing again. It's currently impossible to keep it visible. It works properly on MainSite.
  2. MainSite: when the site loads, two errors appear in the console:
  1. Documentation: navigate to /api/v3/stream/, the following errors show in the console:
  1. Documentation > Get started > API Browser: left-side version-selector panel with namespaces does not appear
  1. added back
  2. changed links to point to docs site, also added route handling to page that handles redirects for any old/missed link
  3. still working on this
  4. I believe those are from an ad blocker in your browser
  5. resolved
  6. haven't started but will look to make changes that easily merge with this commit

Copy link

github-actions bot commented Feb 2, 2024

Preview link: https://www-steeltoe-pr-141.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

@TimHess TimHess marked this pull request as draft February 6, 2024 22:39
@bart-vmware

This comment was marked as resolved.

@TimHess TimHess marked this pull request as ready for review February 15, 2024 22:07
@TimHess TimHess self-assigned this Feb 15, 2024
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

src/Client/Components/Pages/NetworkFileSharing/Index.razor Outdated Show resolved Hide resolved
src/Client/Components/Layout/SiteFooter.razor Show resolved Hide resolved
src/Client/Components/Pages/DynamicLogging/Index.razor Outdated Show resolved Hide resolved
@TimHess TimHess merged commit 41f0255 into main Feb 16, 2024
3 checks passed
@TimHess TimHess deleted the fixes branch February 16, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steeltoe Dynamic logging page returning 400
2 participants