Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap, jquery, copyright and local-mainsite link #310

Merged
merged 12 commits into from
Feb 16, 2024
Merged

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jan 19, 2024

also updates site nav to match mainsite as of SteeltoeOSS/MainSite#141

@TimHess

This comment was marked as resolved.

metadata.json Show resolved Hide resolved
@TimHess TimHess changed the base branch from main to hosting February 6, 2024 22:10
@TimHess TimHess changed the base branch from hosting to main February 6, 2024 22:11
@TimHess TimHess assigned TimHess and unassigned bart-vmware Feb 6, 2024
@TimHess
Copy link
Member Author

TimHess commented Feb 6, 2024

This PR is now (manually) deployed and paired with the mainsite pr preview site

@TimHess TimHess marked this pull request as draft February 6, 2024 22:39
@bart-vmware
Copy link
Member

Menu buttons are still broken. Repro:

  • Click "Why Steeltoe" (expands)
  • Click it again (bug: does not collapse)
  • Click "Get Started" (collapses "Why Steeltoe" and expands "Get Started")
  • Click "Why Steeltoe" (bug: now you see both menus)

image

@bart-vmware

This comment was marked as resolved.

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remarks. Great job on the deployment work, it's nice to be able to test without running the site locally.

Copy link

Preview link: https://docs-steeltoe-pr-310.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

@TimHess TimHess marked this pull request as ready for review February 15, 2024 21:51
bart-vmware

This comment was marked as resolved.

template/steeltoe/styles/main1.js Outdated Show resolved Hide resolved
template/steeltoe/styles/main1.js Outdated Show resolved Hide resolved
@TimHess
Copy link
Member Author

TimHess commented Feb 16, 2024

Looking at #310 (comment), I'm still seeing the following issues:

image

vs MainSite:

image

  • Small browser (a bit wider than above), open hamburger menu: Top-level menu entries are left-aligned instead of centered. And the menu now overlays existing content instead of insertion. Docs:

image

vs MainSite:

image

The differences are caused by significant interference from docfx here... I can try to fix it now, but I'm not sure how much effort it's worth if we follow up on updating docfx (which I think is something we should do soon)

@bart-vmware

This comment was marked as resolved.

@bart-vmware

This comment was marked as resolved.

@TimHess TimHess merged commit 5a96f33 into main Feb 16, 2024
2 checks passed
@TimHess TimHess deleted the updates branch February 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants