Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add Type Check for decimal input (backport #53217) #53258

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2024

Why I'm doing:

2024-11-26 22:03:42.671+08:00 WARN (starrocks-mysql-nio-pool-0|168) [StmtExecutor.execute():792] execute Exception, sql explain SELECT  SUM((gmv+gmv2)*0.01) FROM test_pt8 WHERE pt = '20241126' AND id IN ( SELECT id FROM test_pt9 WHERE id = '1' )
 com.starrocks.sql.common.StarRocksPlannerException: Invalid plan:
PhysicalHashAggregate {type=GLOBAL, groupBy=[], partitionBy=[] ,aggregations={16: sum=sum(16: sum)}}
->  PhysicalDistributionOperator {distributionSpec=GATHER ,globalDict=[]}
    ->  PhysicalHashAggregate {type=LOCAL, groupBy=[], partitionBy=[] ,aggregations={16: sum=sum(14: sum)}}
        ->  PhysicalHashJoinOperator{joinType=LEFT SEMI JOIN, joinPredicate=1: id = 5: id, limit=-1, predicate=null}
            ->  PhysicalHashAggregate {type=GLOBAL, groupBy=[11: id], partitionBy=[11: id] ,aggregations={15: sum=sum(13: sum_channel_direct_indirect_gmv)}}
                ->  PhysicalOlapScanOperator {table=674355, selectedPartitionId=[674362], selectedIndexId=674356, outputColumns=[11: id, 12: pt, 13: sum_channel_direct_indirect_gmv], projection=null, predicate=null, prunedPartitionPredicates=[12: pt = 2024-11-26], limit=-1}
            ->  PhysicalDistributionOperator {distributionSpec=BUCKET[5(false)] ,globalDict=[]}
                ->  PhysicalOlapScanOperator {table=674341, selectedPartitionId=[674348], selectedIndexId=674342, outputColumns=[5: id], projection=null, predicate=5: id IS NOT NULL AND 5: id = 1, prunedPartitionPredicates=[], limit=-1}expr 'Type check failed.' actual type is 16: sum [DECIMAL128]
        at com.starrocks.sql.optimizer.validate.PlanValidator.validatePlan(PlanValidator.java:65)
        at com.starrocks.sql.optimizer.Optimizer.optimizeByCost(Optimizer.java:321)
        at com.starrocks.sql.optimizer.Optimizer.optimize(Optimizer.java:205)
        at com.starrocks.sql.StatementPlanner.createQueryPlanWithReTry(StatementPlanner.java:340)
        at com.starrocks.sql.StatementPlanner.plan(StatementPlanner.java:146)
        at com.starrocks.sql.StatementPlanner.plan(StatementPlanner.java:104)
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:581)
        at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:367)
        at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:567)
        at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:905)
        at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:69)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

Why I'm doing:

2024-11-26 22:03:42.671+08:00 WARN (starrocks-mysql-nio-pool-0|168) [StmtExecutor.execute():792] execute Exception, sql explain SELECT  SUM((gmv+gmv2)*0.01) FROM test_pt8 WHERE pt = '20241126' AND id IN ( SELECT id FROM test_pt9 WHERE id = '1' )
 com.starrocks.sql.common.StarRocksPlannerException: Invalid plan:
PhysicalHashAggregate {type=GLOBAL, groupBy=[], partitionBy=[] ,aggregations={16: sum=sum(16: sum)}}
->  PhysicalDistributionOperator {distributionSpec=GATHER ,globalDict=[]}
    ->  PhysicalHashAggregate {type=LOCAL, groupBy=[], partitionBy=[] ,aggregations={16: sum=sum(14: sum)}}
        ->  PhysicalHashJoinOperator{joinType=LEFT SEMI JOIN, joinPredicate=1: id = 5: id, limit=-1, predicate=null}
            ->  PhysicalHashAggregate {type=GLOBAL, groupBy=[11: id], partitionBy=[11: id] ,aggregations={15: sum=sum(13: sum_channel_direct_indirect_gmv)}}
                ->  PhysicalOlapScanOperator {table=674355, selectedPartitionId=[674362], selectedIndexId=674356, outputColumns=[11: id, 12: pt, 13: sum_channel_direct_indirect_gmv], projection=null, predicate=null, prunedPartitionPredicates=[12: pt = 2024-11-26], limit=-1}
            ->  PhysicalDistributionOperator {distributionSpec=BUCKET[5(false)] ,globalDict=[]}
                ->  PhysicalOlapScanOperator {table=674341, selectedPartitionId=[674348], selectedIndexId=674342, outputColumns=[5: id], projection=null, predicate=5: id IS NOT NULL AND 5: id = 1, prunedPartitionPredicates=[], limit=-1}expr 'Type check failed.' actual type is 16: sum [DECIMAL128]
        at com.starrocks.sql.optimizer.validate.PlanValidator.validatePlan(PlanValidator.java:65)
        at com.starrocks.sql.optimizer.Optimizer.optimizeByCost(Optimizer.java:321)
        at com.starrocks.sql.optimizer.Optimizer.optimize(Optimizer.java:205)
        at com.starrocks.sql.StatementPlanner.createQueryPlanWithReTry(StatementPlanner.java:340)
        at com.starrocks.sql.StatementPlanner.plan(StatementPlanner.java:146)
        at com.starrocks.sql.StatementPlanner.plan(StatementPlanner.java:104)
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:581)
        at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:367)
        at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:567)
        at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:905)
        at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:69)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Nov 27, 2024

@wanpengfei-git wanpengfei-git merged commit 76c68d2 into branch-3.2 Dec 5, 2024
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-53217 branch December 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants