Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] optimize scheduler one task cost (backport #50328) #53179

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 25, 2024

Why I'm doing:

In our cluster with more than 200 routine load jobs, when I trace com.starrocks.load.routineload.RoutineLoadTaskScheduler:scheduleOneTask, some times get very slow in checkTaskInJob

`---ts=2024-07-30 22:59:08;thread_name=pool-17-thread-47;id=b0a;is_daemon=false;priority=5;TCCL=sun.misc.Launcher$AppClassLoader@63947c6b
    `---[28802.292221ms] com.starrocks.load.routineload.RoutineLoadManager:checkTaskInJob()
        +---[0.00% 0.001172ms ] com.starrocks.load.routineload.RoutineLoadManager:readLock() #622
        +---[100.00% min=9.12E-4ms,max=626.112241ms,total=28802.075645ms,count=107] com.starrocks.load.routineload.RoutineLoadJob:containsTask() #625
        `---[0.00% 0.003156ms ] com.starrocks.load.routineload.RoutineLoadManager:readUnlock() #631

What I'm doing:

Replace RoutineLoadMgr::checkTaskInJob with only check whether task in current job, than check task in all current jobs.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50328 done by [Mergify](https://mergify.com). ## Why I'm doing:

In our cluster with more than 200 routine load jobs, when I trace com.starrocks.load.routineload.RoutineLoadTaskScheduler:scheduleOneTask, some times get very slow in checkTaskInJob

`---ts=2024-07-30 22:59:08;thread_name=pool-17-thread-47;id=b0a;is_daemon=false;priority=5;TCCL=sun.misc.Launcher$AppClassLoader@63947c6b
    `---[28802.292221ms] com.starrocks.load.routineload.RoutineLoadManager:checkTaskInJob()
        +---[0.00% 0.001172ms ] com.starrocks.load.routineload.RoutineLoadManager:readLock() #622
        +---[100.00% min=9.12E-4ms,max=626.112241ms,total=28802.075645ms,count=107] com.starrocks.load.routineload.RoutineLoadJob:containsTask() #625
        `---[0.00% 0.003156ms ] com.starrocks.load.routineload.RoutineLoadManager:readUnlock() #631

What I'm doing:

Replace RoutineLoadMgr::checkTaskInJob with only check whether task in current job, than check task in all current jobs.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: hoffermei <[email protected]>
(cherry picked from commit 5320302)
Copy link

sonarcloud bot commented Nov 26, 2024

@wanpengfei-git wanpengfei-git merged commit a7311aa into branch-3.3 Nov 26, 2024
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-50328 branch November 26, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants