Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] optimize scheduler one task cost #50328

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Enhancement] optimize scheduler one task cost #50328

merged 1 commit into from
Nov 25, 2024
+27 −10

Conversation

hoffermei
Copy link
Contributor

@hoffermei hoffermei commented Aug 27, 2024 •
edited by wyb
Loading

Why I'm doing:

In our cluster with more than 200 routine load jobs, when I trace com.starrocks.load.routineload.RoutineLoadTaskScheduler:scheduleOneTask, some times get very slow in checkTaskInJob

`---ts=2024-07-30 22:59:08;thread_name=pool-17-thread-47;id=b0a;is_daemon=false;priority=5;TCCL=sun.misc.Launcher$AppClassLoader@63947c6b
    `---[28802.292221ms] com.starrocks.load.routineload.RoutineLoadManager:checkTaskInJob()
        +---[0.00% 0.001172ms ] com.starrocks.load.routineload.RoutineLoadManager:readLock() #622
        +---[100.00% min=9.12E-4ms,max=626.112241ms,total=28802.075645ms,count=107] com.starrocks.load.routineload.RoutineLoadJob:containsTask() #625
        `---[0.00% 0.003156ms ] com.starrocks.load.routineload.RoutineLoadManager:readUnlock() #631

What I'm doing:

Replace RoutineLoadMgr::checkTaskInJob with only check whether task in current job, than check task in all current jobs.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@hoffermei hoffermei force-pushed the optimize_routine_load_schedule_cost branch from b6f672d to 0cfa06d Compare August 27, 2024 09:56
@hoffermei hoffermei closed this Aug 27, 2024
@hoffermei hoffermei reopened this Aug 27, 2024
@hoffermei hoffermei changed the title optimize scheduler one task cost [Enhancement] optimize scheduler one task cost Aug 27, 2024
@hoffermei hoffermei force-pushed the optimize_routine_load_schedule_cost branch from 0cfa06d to d2fe7c7 Compare September 5, 2024 10:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hoffermei hoffermei force-pushed the optimize_routine_load_schedule_cost branch from d2fe7c7 to 577de79 Compare November 20, 2024 08:18
@hoffermei hoffermei force-pushed the optimize_routine_load_schedule_cost branch from 577de79 to c43fc75 Compare November 20, 2024 08:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/routineload/RoutineLoadTaskScheduler.java 1 1 100.00% []
🔵 com/starrocks/load/routineload/RoutineLoadMgr.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions github-actions bot removed the 3.0 label Nov 25, 2024
@wyb wyb enabled auto-merge (squash) November 25, 2024 08:26
@wyb wyb merged commit 5320302 into StarRocks:main Nov 25, 2024
62 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@hoffermei @mergify
[Enhancement] optimize scheduler one task cost (#50328)
3f04db5 
Signed-off-by: hoffermei <[email protected]>
(cherry picked from commit 5320302)
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@hoffermei @mergify
[Enhancement] optimize scheduler one task cost (#50328)
fbfe0fb 
Signed-off-by: hoffermei <[email protected]>
(cherry picked from commit 5320302)
This was referenced Nov 25, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@hoffermei @mergify
[Enhancement] optimize scheduler one task cost (#50328)
4ddb672 
Signed-off-by: hoffermei <[email protected]>
(cherry picked from commit 5320302)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 26, 2024
@mergify @hoffermei
[Enhancement] optimize scheduler one task cost (backport #50328) (#53179
a7311aa 
)

Co-authored-by: hoffer <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Nov 26, 2024
@mergify @hoffermei
[Enhancement] optimize scheduler one task cost (backport #50328) (#53180
b570fd1 
)

Co-authored-by: hoffer <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Nov 26, 2024
@mergify @hoffermei
[Enhancement] optimize scheduler one task cost (backport #50328) (#53181
52a20e4 
)

Co-authored-by: hoffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banmoy banmoy banmoy approved these changes

@meegoo meegoo meegoo approved these changes

@wyb wyb wyb approved these changes

@gengjun-git gengjun-git Awaiting requested review from gengjun-git

Assignees

@hoffermei hoffermei

Labels
2.5 3.1-merged 3.2-merged 3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoffermei @wyb @meegoo @banmoy