-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix show keys from support external catalog #52977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Astralidea <[email protected]>
Signed-off-by: Astralidea <[email protected]>
Signed-off-by: Astralidea <[email protected]>
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
meegoo
approved these changes
Nov 20, 2024
Youngwb
approved these changes
Nov 20, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Astralidea <[email protected]> (cherry picked from commit c38a677) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Astralidea <[email protected]> (cherry picked from commit c38a677) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
This was referenced Nov 20, 2024
Astralidea
added a commit
that referenced
this pull request
Nov 20, 2024
#53066) Signed-off-by: Astralidea <[email protected]>
This was referenced Nov 20, 2024
Astralidea
added a commit
that referenced
this pull request
Nov 20, 2024
#53067) Signed-off-by: Astralidea <[email protected]>
Smith-Cruise
pushed a commit
to Smith-Cruise/starrocks
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Astralidea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When Power BI connects to external tables, it executes the
SHOW KEYS FROM $database.$table
statement. This statement is supported for internal tables but not for external tables, resulting in Power BI failing to connect to external tables.What I'm doing:
To fix this issue, modify the
SHOW KEYS FROM
statement to take the catalog into account, ensuring that the corresponding database and table can be located properly.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: