Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix show keys from support external catalog #52977

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

Astralidea
Copy link
Contributor

Why I'm doing:

When Power BI connects to external tables, it executes the SHOW KEYS FROM $database.$table statement. This statement is supported for internal tables but not for external tables, resulting in Power BI failing to connect to external tables.

What I'm doing:

To fix this issue, modify the SHOW KEYS FROM statement to take the catalog into account, ensuring that the corresponding database and table can be located properly.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Astralidea <[email protected]>
@Astralidea Astralidea enabled auto-merge (squash) November 19, 2024 02:11
Signed-off-by: Astralidea <[email protected]>
Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/ShowExecutor.java 4 4 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea merged commit c38a677 into StarRocks:main Nov 20, 2024
47 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 20, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 20, 2024
Copy link
Contributor

mergify bot commented Nov 20, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 20, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2024
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit c38a677)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit c38a677)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
Astralidea added a commit that referenced this pull request Nov 20, 2024
Astralidea added a commit that referenced this pull request Nov 20, 2024
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants