Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix show keys from support external catalog (backport #52977) #53067

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented Nov 20, 2024

Why I'm doing:

When Power BI connects to external tables, it executes the SHOW KEYS FROM $database.$table statement. This statement is supported for internal tables but not for external tables, resulting in Power BI failing to connect to external tables.

What I'm doing:

To fix this issue, modify the SHOW KEYS FROM statement to take the catalog into account, ensuring that the corresponding database and table can be located properly.

Fixes #52977

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Copy link

sonarcloud bot commented Nov 20, 2024

@Astralidea Astralidea enabled auto-merge (squash) November 20, 2024 21:59
@Astralidea Astralidea merged commit b9c3b9d into StarRocks:branch-3.2 Nov 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants