Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] fix flaky test test_mv_swap #52076

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[UT] fix flaky test test_mv_swap #52076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deba8fe
fix test
murphyatwork Oct 18, 2024
cc77c47
mark sequential
murphyatwork Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/sql/test_materialized_view/R/test_mv_swap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
-- name: test_mv_swap
-- name: test_mv_swap @sequential
admin set frontend config('enable_mv_automatic_active_check'='false');
-- result:
-- !result
create database db_${uuid0};
-- result:
-- !result
Expand Down Expand Up @@ -177,4 +180,7 @@ true
-- !result
[UC]drop database db_${uuid0} force;
-- result:
-- !result
admin set frontend config('enable_mv_automatic_active_check'='true');
-- result:
-- !result
8 changes: 6 additions & 2 deletions test/sql/test_materialized_view/T/test_mv_swap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
-- name: test_mv_swap
-- name: test_mv_swap @sequential

admin set frontend config('enable_mv_automatic_active_check'='false');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this case be marked as @Sequential ? so the change of frontend configuration won't affect other cases that may be running in the same time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

create database db_${uuid0};
use db_${uuid0};
Expand Down Expand Up @@ -73,4 +75,6 @@ SELECT IS_ACTIVE, INACTIVE_REASON FROM information_schema.materialized_views WHE
ALTER MATERIALIZED VIEW mv_on_table_1 ACTIVE;
SELECT IS_ACTIVE, INACTIVE_REASON FROM information_schema.materialized_views WHERE table_name = 'mv_on_table_1';

[UC]drop database db_${uuid0} force;
[UC]drop database db_${uuid0} force;

admin set frontend config('enable_mv_automatic_active_check'='true');
Loading