Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT] fix flaky test test_mv_swap #52076

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Oct 18, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Murphy <[email protected]>
@@ -1,5 +1,7 @@
-- name: test_mv_swap

admin set frontend config('enable_mv_automatic_active_check'='false');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this case be marked as @Sequential ? so the change of frontend configuration won't affect other cases that may be running in the same time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) October 18, 2024 08:21
@murphyatwork murphyatwork merged commit 8d26a4d into StarRocks:main Oct 18, 2024
41 of 42 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 18, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 18, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 18, 2024
Copy link
Contributor

mergify bot commented Oct 18, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 18, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 18, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 8d26a4d)
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 8d26a4d)

# Conflicts:
#	test/sql/test_materialized_view/T/test_mv_swap
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 8d26a4d)

# Conflicts:
#	test/sql/test_materialized_view/R/test_mv_swap
#	test/sql/test_materialized_view/T/test_mv_swap
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
murphyatwork added a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 8d26a4d)
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
murphyatwork added a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 8d26a4d)
murphyatwork added a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 8d26a4d)
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants