[BugFix] Fix tablet not release if ingestion transaction is abort (backport #51932) #51971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…1932) ## Why I'm doing: We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which will result in delayed disk space reclamation. ## What I'm doing: Do not wait timeout if find the delta writer state is abort. Fixes StarRocks/StarRocksTest#8666 Signed-off-by: sevev <[email protected]> (cherry picked from commit 95f29c4)
24 tasks
sevev
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which will result in delayed disk space reclamation.
What I'm doing:
Do not wait timeout if find the delta writer state is abort.
Fixes https://github.com/StarRocks/StarRocksTest/issues/8666
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #51932 done by [Mergify](https://mergify.com). ## Why I'm doing: We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which will result in delayed disk space reclamation.
What I'm doing:
Do not wait timeout if find the delta writer state is abort.
Fixes https://github.com/StarRocks/StarRocksTest/issues/8666
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: