Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix tablet not release if ingestion transaction is abort #51932

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[BugFix] Fix tablet not release if ingestion transaction is abort #51932

merged 2 commits into from
Oct 16, 2024

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Oct 15, 2024 •
edited
Loading

Why I'm doing:

We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which will result in delayed disk space reclamation.

What I'm doing:

Do not wait timeout if find the delta writer state is abort.

Fixes https://github.com/StarRocks/StarRocksTest/issues/8666

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sevev sevev requested a review from a team as a code owner October 15, 2024 08:13
@github-actions github-actions bot added the 3.3 label Oct 15, 2024
@mergify mergify bot assigned sevev Oct 15, 2024
@sevev
update
6387234 
Signed-off-by: sevev <[email protected]>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/local_tablets_channel.cpp 2 2 100.00% []

@github-actions github-actions bot added the 3.2 label Oct 16, 2024
@sevev sevev merged commit 95f29c4 into StarRocks:main Oct 16, 2024
60 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 16, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 16, 2024
@sevev @mergify
[BugFix] Fix tablet not release if ingestion transaction is abort (#5…
991cc6c 
…1932)

## Why I'm doing:
We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which  will result in delayed disk space reclamation.

## What I'm doing:
Do not wait timeout if find the delta writer state is abort.

Fixes StarRocks/StarRocksTest#8666

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 95f29c4)

# Conflicts:
#	be/src/runtime/local_tablets_channel.cpp
@mergify mergify bot mentioned this pull request Oct 16, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
@sevev @mergify
[BugFix] Fix tablet not release if ingestion transaction is abort (#5…
853902d 
…1932)

## Why I'm doing:
We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which  will result in delayed disk space reclamation.

## What I'm doing:
Do not wait timeout if find the delta writer state is abort.

Fixes StarRocks/StarRocksTest#8666

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 95f29c4)
@mergify mergify bot mentioned this pull request Oct 16, 2024
Open
42 tasks
@sevev
Copy link
Contributor Author

sevev commented Oct 16, 2024

@mergify backport branch-3.3.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024 •
edited
Loading

backport branch-3.3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 16, 2024
@sevev @mergify
[BugFix] Fix tablet not release if ingestion transaction is abort (#5…
8b8475d 
…1932)

## Why I'm doing:
We will back pressure OlapTableSink since there are too many memtables need to flush. However, if table is dropped by force and we will abort the running ingestion task and remove all the flush memtable task in the task queue. However, we do not clear the statistic, we will release tablet until the request time out which  will result in delayed disk space reclamation.

## What I'm doing:
Do not wait timeout if find the delta writer state is abort.

Fixes StarRocks/StarRocksTest#8666

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 95f29c4)
@mergify mergify bot mentioned this pull request Oct 16, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 16, 2024
@mergify @sevev
[BugFix] Fix tablet not release if ingestion transaction is abort (ba…
2791215 
…ckport #51932) (#51971)

Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 19, 2024
@mergify @sevev
[BugFix] Fix tablet not release if ingestion transaction is abort (ba…
ec224d7 
…ckport #51932) (#51969)

Signed-off-by: sevev <[email protected]>
Co-authored-by: zhangqiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meegoo meegoo meegoo approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@sevev sevev

Labels
3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevev @meegoo @stdpain