Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add some util in script for TDE debug; Fix memleak in wrenbind (backport #51813) #51919

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2024

Why I'm doing:

It's hard to debug TDE related issue, also there are ASAN memleaks in wren script engine

What I'm doing:

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51813 done by [Mergify](https://mergify.com). ## Why I'm doing:

It's hard to debug TDE related issue, also there are ASAN memleaks in wren script engine

What I'm doing:

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Oct 15, 2024
Copy link
Contributor Author

mergify bot commented Oct 15, 2024

Cherry-pick of e837fe3 has failed:

On branch mergify/bp/branch-3.3/pr-51813
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit e837fe30e7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/script/script.cpp
	modified:   be/src/storage/rowset/rowset.cpp
	modified:   be/src/thirdparty/wrenbind17/wrenbind17/vm.hpp
	modified:   be/test/fs/key_cache_test.cpp
	modified:   be/test/storage/lake/tablet_manager_test.cpp
	modified:   be/test/storage/lake/tablet_reader_test.cpp
	modified:   be/test/storage/rowset/rowset_test.cpp
	modified:   be/test/storage/tablet_updates_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/lake/rowset.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Oct 15, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@decster decster reopened this Oct 15, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 15, 2024 07:57
@decster decster force-pushed the mergify/bp/branch-3.3/pr-51813 branch 2 times, most recently from 1a20eaa to 107ba81 Compare October 15, 2024 08:54
…renbind (#51813)

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind;

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit e837fe3)
@decster decster force-pushed the mergify/bp/branch-3.3/pr-51813 branch from 107ba81 to 1f02d2b Compare October 15, 2024 09:36
@wanpengfei-git wanpengfei-git merged commit 4d01136 into branch-3.3 Oct 15, 2024
26 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-51813 branch October 15, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants