Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add some util in script for TDE debug; Fix memleak in wrenbind #51813

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[Enhancement] Add some util in script for TDE debug; Fix memleak in wrenbind #51813

merged 1 commit into from
Oct 15, 2024

Conversation

decster
Copy link
Contributor

@decster decster commented Oct 11, 2024 •
edited
Loading

Why I'm doing:

It's hard to debug TDE related issue, also there are ASAN memleaks in wren script engine

What I'm doing:

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@decster decster requested review from a team as code owners October 11, 2024 15:56
@github-actions github-actions bot added the 3.3 label Oct 11, 2024
@decster decster requested a review from a team as a code owner October 12, 2024 14:50
@decster decster changed the title [Enhancement] Add some util in script for TDE debug [Enhancement] Add some util in script for TDE debug; Fix memleak in wrenbind Oct 14, 2024
@decster decster force-pushed the tde-script branch 2 times, most recently from 8c77e48 to 881e613 Compare October 14, 2024 15:36
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 25 / 31 (80.65%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/rowset.cpp 5 10 50.00% [429, 430, 474, 491, 493]
🔵 be/src/script/script.cpp 15 16 93.75% [301]
🔵 be/src/storage/rowset/rowset.cpp 5 5 100.00% []

@decster decster merged commit e837fe3 into StarRocks:main Oct 15, 2024
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 15, 2024
@decster @mergify
[Enhancement] Add some util in script for TDE debug; Fix memleak in w…
a3556df 
…renbind (#51813)

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind;

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit e837fe3)

# Conflicts:
#	be/src/storage/lake/rowset.cpp
@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
42 tasks
decster added a commit that referenced this pull request Oct 15, 2024
@decster
[Enhancement] Add some util in script for TDE debug; Fix memleak in w…
1a20eaa 
…renbind (#51813)

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind;

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit e837fe3)
decster added a commit that referenced this pull request Oct 15, 2024
@decster
[Enhancement] Add some util in script for TDE debug; Fix memleak in w…
107ba81 
…renbind (#51813)

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind;

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit e837fe3)
decster added a commit that referenced this pull request Oct 15, 2024
@decster
[Enhancement] Add some util in script for TDE debug; Fix memleak in w…
1f02d2b 
…renbind (#51813)

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind;

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit e837fe3)
wanpengfei-git pushed a commit that referenced this pull request Oct 15, 2024
@mergify @decster
[Enhancement] Add some util in script for TDE debug; Fix memleak in w…
4d01136 
…renbind (backport #51813) (#51919)

Co-authored-by: Binglin Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@luohaha luohaha luohaha approved these changes

Assignees

@decster decster

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decster @kevincai @luohaha