[BugFix] fix no matching function error in array_contains/array_position #51835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
fix_array_contains
branch
from
782b4f7
to
f6b7f9e
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 16 / 17 (94.12%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
satanson
approved these changes
Oct 14, 2024
LiShuMing
approved these changes
Oct 14, 2024
Seaven
approved these changes
Oct 14, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ion (#51835) Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 8cc2ae2)
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ion (#51835) Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 8cc2ae2) # Conflicts: # test/sql/test_array_fn/R/test_array_contains # test/sql/test_array_fn/T/test_array_contains
silverbullet233
added a commit
that referenced
this pull request
Oct 15, 2024
…ion (#51835) Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 8cc2ae2)
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ion (backport #51835) (#51879) Co-authored-by: eyes_on_me <[email protected]>
|
@mergify backport branch-3.3.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ion (#51835) Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 8cc2ae2)
Merged
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ion (backport #51835) (#51937) Co-authored-by: eyes_on_me <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/8662
introduced by: #50912
taking
array_containsas an example,before #50912,
array_containshad only one function signaturearray_contains(ANY_ARRAY,ANY_ELEMENT). in #50912, I added many type-specialized function signatures for it and special handings innormalizeDecimalArgTypes.FunctionAnalyzer will determine whether to follow the logic of
getDecimalV3Functionbased on whether the arguments contain decimal type.array_containsis a bit special. forarray_contains(array<array<decimal>>, array<decimal>), the second argument will hit the check logic ofargumentTypeContainDecimalV3and go togetDecimalV3Function. sincearray<decimal>anddecimaldon't have a common type, the subsequent processing will cause errors.In fact, this situation should not follow the processing logic of
getDecimalV3Function, so I made a special judgment in this pr to solve this problem.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: