Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix array_map's error result when inputs are constant #51833

Merged
merged 3 commits into from
Oct 14, 2024
Merged

[BugFix] fix array_map's error result when inputs are constant #51833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc729e8
fix array_map's error result when inputs are constant
silverbullet233 Oct 12, 2024
e17332d
fix format
silverbullet233 Oct 12, 2024
39df0a0
fix
silverbullet233 Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions be/src/exprs/array_map_expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,12 @@ StatusOr<ColumnPtr> ArrayMapExpr::evaluate_lambda_expr(ExprContext* context, Chu
auto array_column = down_cast<const ArrayColumn*>(data_column.get());
auto elements_column = array_column->elements_column();
UInt32Column::Ptr offsets_column = array_column->offsets_column();
if constexpr (!all_const_input) {
if (input_elements[i]->is_constant()) {

if (input_elements[i]->is_constant()) {
if (!all_const_input || !capture_slot_ids.empty()) {
// if not all input columns are constant,
// or all input columns are constant but lambda expr depends on other capture columns(e.g. array_map(x->x+k,[1,2,3])),
// we should unpack the const column before evaluation
size_t elements_num = array_column->get_element_size(0);
elements_column = elements_column->clone();
offsets_column = UInt32Column::create();
Expand All @@ -114,13 +118,13 @@ StatusOr<ColumnPtr> ArrayMapExpr::evaluate_lambda_expr(ExprContext* context, Chu
offset += elements_num;
offsets_column->append(offset);
}
} else {
if (result_null_column != nullptr) {
data_column->empty_null_in_complex_column(result_null_column->get_data(),
array_column->offsets().get_data());
}
elements_column = down_cast<const ArrayColumn*>(data_column.get())->elements_column();
}
} else {
if (result_null_column != nullptr) {
data_column->empty_null_in_complex_column(result_null_column->get_data(),
array_column->offsets().get_data());
}
elements_column = down_cast<const ArrayColumn*>(data_column.get())->elements_column();
}

if (aligned_offsets == nullptr) {
Expand Down Expand Up @@ -173,8 +177,9 @@ StatusOr<ColumnPtr> ArrayMapExpr::evaluate_lambda_expr(ExprContext* context, Chu
column = tmp_col->replicate(aligned_offsets->get_data());
column = ColumnHelper::align_return_type(column, type().children[0], column->size(), true);
} else {
// if all input arguments are const,
if constexpr (all_const_input) {
// if all input arguments are constant and lambda expr doesn't rely on other capture columns,
// we can evaluate it based on const column
if (all_const_input && capture_slot_ids.empty()) {
ASSIGN_OR_RETURN(auto tmp_col, context->evaluate(_children[0], cur_chunk.get()));
tmp_col->check_or_die();
// if result is a const column, we should unpack it first and make it to be the elements column of array column
Expand All @@ -200,8 +205,9 @@ StatusOr<ColumnPtr> ArrayMapExpr::evaluate_lambda_expr(ExprContext* context, Chu
DCHECK(column != nullptr);
column = ColumnHelper::cast_to_nullable_column(column);

if constexpr (all_const_input) {
// if all input arguments are const, we can return a const column
if (all_const_input && capture_slot_ids.empty()) {
// if all input arguments are const and lambdaexpr doesn't depend on other capture columns,
// we can return a const column
auto data_column = FunctionHelper::get_data_column_of_const(column);

aligned_offsets = UInt32Column::create();
silverbullet233 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
6 changes: 3 additions & 3 deletions test/sql/test_array_fn/R/test_array_map_2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ None
select array_map((x,y)->k, [1,2],[2,3]) from t order by k;
-- result:
[1,1]
[1,1]
[1,1]
[1,1]
[2,2]
[3,3]
[4,4]
-- !result
select array_map((x,y,z)->x+y+z, [1,2],[2,3],[3,4]) from t;
-- result:
Expand Down
Loading