Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix array_map's error result when inputs are constant #51833

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Oct 12, 2024

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/8662

introduced by: #51244

for scenarios where all inputs are constant, we will directly evaluate lambda expr based on the const column to avoid extra overhead. In this case, we will not unpack the const column or align the offset with capture columns.
However, there is an exception, such as array_map(x->array_length(x) > c1+1, [[1,2,3]]), where the lambda expression depends on other capture columns. In this case, we cannot follow the above strategy and still need to unpack the const and follow the normal process, otherwise it will get a wrong result.
in this pr, I fixed it.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 changed the title [BugFix] fix array_map's error result when inputs are constant [BugFix][UT] fix array_map's error result when inputs are constant Oct 12, 2024
@silverbullet233 silverbullet233 changed the title [BugFix][UT] fix array_map's error result when inputs are constant [BugFix] fix array_map's error result when inputs are constant Oct 12, 2024
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 8 / 8 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/array_map_expr.cpp 8 8 100.00% []

@silverbullet233 silverbullet233 merged commit 48db7f5 into StarRocks:main Oct 14, 2024
53 checks passed
@silverbullet233 silverbullet233 deleted the fix_array_map branch October 14, 2024 06:18
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 14, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 14, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 14, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 14, 2024
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 14, 2024
@silverbullet233
Copy link
Contributor Author

@mergify backport branch-3.3.5

Copy link
Contributor

mergify bot commented Oct 15, 2024

backport branch-3.3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 15, 2024
silverbullet233 added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants