Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggested TODO items #26

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add suggested TODO items #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e921afe
Add suggested TODO items
manopapad Sep 27, 2023
ddc00d0
Update TODO.md
manopapad Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,41 @@
- [x] Filter by kind
- [x] Task detail view
- [ ] Horizontal pan (including drag, keyboard, horizontal scroll wheel)
- [ ] Keyboard bindings (e.g., arrow keys to select panels, space bar to toggle expand/collapse)
- [ ] Keyboard bindings (e.g., arrow keys to select panels, space bar to toggle expand/collapse, ESC key to close popups)
- [ ] Editable key bindings?
- [ ] Better error handling (e.g., when the provided URL 404s, or parsing fails)
- [ ] Better error handling (e.g., when the provided URL 404s, there's a permission issue, or parsing fails)
- [ ] Make text in popup boxes copyable
- [ ] Make highlighted boxes clearer

Currently a highlighted box is shown in red, but that color is already in use in the default color scheme, so highlighted items don't stand out

Possible solutions:

- "halo" effect for highlighted box
- different fill pattern
- different line color
- saturate all other boxes except the highlighted one (as happens for search)
Comment on lines +33 to +40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent to line up with the first line of the bullet, so it gets parsed properly as Markdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it this way

Screenshot 2023-09-27 at 5 31 11 PM

results in github misparsing it as a code block:

Screenshot 2023-09-27 at 5 31 23 PM

The original parses properly (at least by github):

Screenshot 2023-09-27 at 5 33 12 PM


- [ ] When user clicks "zoom to item", e.g. on an instance listed in a task box, also open that new item's popup
- [ ] Have the tooltip box wrap text / scroll vertically if the contents are too long,
e.g. if we're trying to show full backtraces on provenance, or there's many field names to list
- [ ] Color instances using a heat map based on size
- [ ] The "zoom reset" keyboard shortcut (ctrl + left arrow) doesn't work on MacOS (at least Safari)
- [ ] Thousands separator on large numbers
- [ ] Add average bandwidth measure on copies
- [ ] Add button for "export current view to image"
- [ ] Report both field IDs and field names
- [ ] On each instance box, add a "zoom to item" button to the "initiator" (i.e. the task that created that instance?)
- [ ] Provenance strings that contain a machine-readable part (after a `$` delimiter) are not parsed

E.g. a full provenance string like:

foo.py:42$OpCode,MULTIPLY|Provenance,foo.py:42

should be getting reported as:

foo.py:42
OpCode=MULTIPLY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but I actually want to make a proposal to change this format entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ddc00d0


- [ ] Include in the window title the directory where the profile logs are
- [ ] In server mode, add a form on the top-level served page, where the user can specify which files to open, instead of having to enter this information manually on the URL as a GET `url=` parameter
Loading