Add suggested TODO items #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included some of my own wishlist items, plus items from StanfordLegion/legion#1551 and StanfordLegion#25
Comment on lines
+33
to
+40
| Currently a highlighted box is shown in red, but that color is already in use in the default color scheme, so highlighted items don't stand out | ||
|
|
||
| Possible solutions: | ||
|
|
||
| - "halo" effect for highlighted box | ||
| - different fill pattern | ||
| - different line color | ||
| - saturate all other boxes except the highlighted one (as happens for search) |
There was a problem hiding this comment.
Indent to line up with the first line of the bullet, so it gets parsed properly as Markdown.
There was a problem hiding this comment.
Doing it this way
results in github misparsing it as a code block:
The original parses properly (at least by github):
TODO.md
Outdated
Comment on lines
52
to
61
| - [ ] Provenance strings that contain a machine-readable part (after a `$` delimiter) are not parsed | ||
|
|
||
| E.g. a full provenance string like: | ||
|
|
||
| foo.py:42$OpCode,MULTIPLY|Provenance,foo.py:42 | ||
|
|
||
| should be getting reported as: | ||
|
|
||
| foo.py:42 | ||
| OpCode=MULTIPLY |
There was a problem hiding this comment.
This is fine but I actually want to make a proposal to change this format entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included some of my own wishlist items, plus items from StanfordLegion/legion#1551 and #25