Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix silence periods #3557

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Fix silence periods #3557

merged 5 commits into from
Dec 9, 2024

Conversation

yger
Copy link
Collaborator

@yger yger commented Nov 29, 2024

This is an attempt to fix #3554, despite the fact that I can not reproduce per se the bug

@yger yger mentioned this pull request Nov 29, 2024
Closed
@alejoe91 alejoe91 added the preprocessing Related to preprocessing module label Dec 2, 2024
@alejoe91
Copy link
Member

alejoe91 commented Dec 2, 2024

@maxjuv can you test if this PR fixes the issue on you side?

@maxjuv
Copy link
Contributor

maxjuv commented Dec 3, 2024

I just tried, the PR fixed the bug.

zm711
zm711 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough and fixes the bug. Works for me :)

@alejoe91 alejoe91 merged commit 665adf8 into SpikeInterface:main Dec 9, 2024
14 of 15 checks passed
@yger yger deleted the fix_silence_periods branch December 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 approved these changes

Assignees
No one assigned
Labels
preprocessing Related to preprocessing module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

silence_periods with mode 'noise' is incompatible with get_noise_levels
4 participants
@yger @alejoe91 @maxjuv @zm711