silence_periods with mode 'noise' is incompatible with get_noise_levels

[maxjuv]

Hello,
I recently added in my preprocessing silence_periods(mode='noise'). Since then I was not able to estimate noise level. I got the following error :

  File "/home/users/j/juventin/local_python_package/spikeinterface/src/spikeinterface/preprocessing/silence_periods.py", line 76, in __init__
    noise_levels = get_noise_levels(
  File "/home/users/j/juventin/local_python_package/spikeinterface/src/spikeinterface/core/recording_tools.py", line 789, in get_noise_levels
    recording_slices = get_random_recording_slices(recording, **random_slices_kwargs)
TypeError: get_random_recording_slices() got an unexpected keyword argument 'noise_generator'

I tracked the error. It happened that during the silence_period preprocessing, 'noise_generator' is added in the recording kwargs

spikeinterface/src/spikeinterface/preprocessing/silence_periods.py

Line 100 in 853d8a4

self._kwargs = dict(recording=recording, list_periods=list_periods, mode=mode, noise_generator=noise_generator)

Then, when estimating the noise levels (get_noise_levels), spikeinterface passes the variables 'noise_generator' in random_slices_kwargs, which is not recognized.
Is it really useful to put 'noise_generator' in the kwargs ?
In my script I solved it by removing 'noise_generator' from the kwargs.

[zm711]

I think this is likely @samuelgarcia , but maybe @alejoe91 knows this?

[yger]

I've made a putative patch in #3557