Add safeguard for probeinterface use of read_spikegadgets
#2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
changed the title
read_spikegadgets
alejoe91
requested changes
May 13, 2024
| probegroup = probeinterface.read_spikegadgets(file_path, raise_error=False) | ||
| probegroup = None | ||
| # If version of probeinterface is larger than 0.2.21 then try this method | ||
| if probeinterface.__version__ > "0.2.21": |
There was a problem hiding this comment.
@h-mayorquin let's use packaging:
from packaging.version import parse
if parse(probeinterface.__version__) > parse("0.2.21"):
There was a problem hiding this comment.
Are you fine with adding packacing as a dependency?
alejoe91
approved these changes
May 13, 2024
|
The failing tests are due to a recent zarr upgrade, which is breaking |
alejoe91
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the
read_spikegadgetsreader in an un unreleased version of probeinterface. I am imaging that tere will be a release of probeinterface soon but unless #2827 is intended to come together with the next probeinterface release this will be needed.