-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change some default parameters for better user experience #2071
Conversation
Not sure with sparsity=True by default. I would throw a warning for num_channels > 64 |
For the user experience sparsity=True make everything faster with less disk space. |
I just want to throw a vote Sam's way on this one. I often forget to set sparsity to True when I'm doing tests on things and so this would be a nice change for me. My logic being : 1) it helps me, 2) so many people are dealing with probes of >32 channels so making the default the better (again my opinion) option and then letting people with smaller probes switch to false if they want seems better. But I could be convinced the other direction, just my gut and disk space is with Sam on this one. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that default sparsity is messing up with all prosptocessing tests. @samuelgarcia can you fix that?
I am so happy
I will try my best. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Change some default parameters for better user experience
close #2008
and also small fix (uncorrelated)