Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some default parameters for better user experience #2071

Merged
merged 17 commits into from
Oct 6, 2023

Conversation

samuelgarcia
Copy link
Member

@samuelgarcia samuelgarcia commented Oct 4, 2023

Change some default parameters for better user experience

  • waveform sparse by default
  • ms_before=1.0, ms_after=2.0,
  • correlogram with bin_ms= 1.0
  • remove_existing_folder: bool = False for run_sorter()

close #2008

and also small fix (uncorrelated)

@alejoe91
Copy link
Member

alejoe91 commented Oct 5, 2023

Not sure with sparsity=True by default. I would throw a warning for num_channels > 64

@samuelgarcia
Copy link
Member Author

For the user experience sparsity=True make everything faster with less disk space.
Even for 32 channels it is better.
I do not see why we should have the "bad" default option and make a warning to user saying : "hey you should use the other option!"

@zm711
Copy link
Collaborator

zm711 commented Oct 5, 2023

I just want to throw a vote Sam's way on this one. I often forget to set sparsity to True when I'm doing tests on things and so this would be a nice change for me. My logic being : 1) it helps me, 2) so many people are dealing with probes of >32 channels so making the default the better (again my opinion) option and then letting people with smaller probes switch to false if they want seems better.

But I could be convinced the other direction, just my gut and disk space is with Sam on this one.

@alejoe91 alejoe91 added the enhancement New feature or request label Oct 5, 2023
Copy link
Member

@alejoe91 alejoe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that default sparsity is messing up with all prosptocessing tests. @samuelgarcia can you fix that?

@samuelgarcia
Copy link
Member Author

I just want to throw a vote Sam's way on this one.

I am so happy

I think that default sparsity is messing up with all prosptocessing tests. @samuelgarcia can you fix that?

I will try my best.

@alejoe91 alejoe91 merged commit d65978e into SpikeInterface:main Oct 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to Change Default Behavior of run_sorter() Function to Prevent Data Loss
3 participants