Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for module_gallery with new sparsity default #2100

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Oct 13, 2023

The waveform extractor example is broken (due to change in sparsity default in #2071:

https://spikeinterface.readthedocs.io/en/latest/modules_gallery/core/plot_4_waveform_extractor.html#sphx-glr-modules-gallery-core-plot-4-waveform-extractor-py

We need to force the dense example to be dense rather than let it default.

@alejoe91
Copy link
Member

Thanks Zach!

@alejoe91 alejoe91 added the documentation Improvements or additions to documentation label Oct 13, 2023
@zm711
Copy link
Collaborator Author

zm711 commented Oct 13, 2023

Failures are unrelated. They are occurring in the sorter class tests.

@alejoe91
Copy link
Member

Yep, @samuelgarcia and @yger broke something in their tools! We shouldn't let them roam too free ;)

@alejoe91 alejoe91 merged commit 8a5f544 into SpikeInterface:main Oct 14, 2023
7 of 8 checks passed
@zm711 zm711 deleted the module-gallery branch October 14, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants