move peak_pipeline into core and rename it as node_pipeline. #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change tests accordingly
for more information, see https://pre-commit.ci
…face into pipeline_in_core
for more information, see https://pre-commit.ci
alejoe91
added
sortingcomponents
alejoe91
reviewed
Aug 29, 2023
alejoe91
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Thansk @samuelgarcia
Can you add scipy to the test_core requirements? That should fix tests!
I saw, I will remove this scipy fft convolve instead to have a light core test. |
…face into pipeline_in_core
for more information, see https://pre-commit.ci
Merged
…to pipeline_in_core
for more information, see https://pre-commit.ci
…to pipeline_in_core
…face into pipeline_in_core
|
@alejoe91 this is ready to be reviewed/merged |
|
@alejoe91 : this is mostly a simple move. Could we merge this ? |
alejoe91
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move peak_pipeline into core and rename it as node_pipeline.
Change tests accordingly.
This PR #1948 must be merged first because we need the new generate mechanisim