Implement Spike retriever #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face into spike_retriever
Merged
|
@alejoe91 this is ready to be reviewed/merged |
alejoe91
requested changes
Sep 1, 2023
Comment on lines
151
to
154
| recording: | ||
|
|
||
| sorting: | ||
|
|
alejoe91
reviewed
Sep 13, 2023
alejoe91
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need #1941 to be merged before.
SpikeRetriever class is usefull to inject a sorting object in the node pipepline mechanisim.
It allows to compute some post processing with the same machinery used for sorting components.
This is a first step to totaly refactor: