Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1679 Enable issue streaming for SLCore analysis #5876

Merged
merged 3 commits into from
Dec 6, 2024
Merged

SLVS-1679 Enable issue streaming for SLCore analysis #5876

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30e2dd5
SLVS-1679 Enable issue streaming for SLCore analysis
georgii-borovinskikh-sonarsource Dec 5, 2024
df7d79c
fix
georgii-borovinskikh-sonarsource Dec 5, 2024
dee887c
remove redundant field
georgii-borovinskikh-sonarsource Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CFamily/Subprocess/MessageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ private void HandleAnalysisIssue(Message message)
// TextBufferIssueTracker when the file was closed, but the TextBufferIssueTracker will
// still exist and handle the call.
// todo https://sonarsource.atlassian.net/browse/SLVS-1661
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the TODO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This links to the cleanup task

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added it after you commented out the line 145 in this commit: 30e2dd5

Then you added back the line, so I assumed the TODO also has to be removed.

If that is not the case, then consider explaining what has to be done in the line and update the task SLVS-1661 to make sure the TODO will be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole class needs to be removed, I reverted the line change because I didn't want to comment out the tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, just update the corresponding Jira task, and everything should be fine. 👍

// issueConsumer.Set(request.Context.File, new[] { issue });
issueConsumer.Set(request.Context.File, new[] { issue });
}

internal /* for testing */ static bool IsIssueForActiveRule(Message message, ICFamilyRulesConfig rulesConfiguration)
Expand Down